-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: current webpack config does not mimic the same functionality for global styles from Angular CLI #1070
Labels
Milestone
Comments
This was referenced Jan 23, 2019
christophercr
added a commit
to christophercr/stark
that referenced
this issue
Jan 23, 2019
…same functionality ISSUES CLOSED: NationalBankBelgium#1070
christophercr
added a commit
to christophercr/stark
that referenced
this issue
Jan 23, 2019
…same functionality for global styles from Angular CLI ISSUES CLOSED: NationalBankBelgium#1070
3 tasks
christophercr
added a commit
to christophercr/stark
that referenced
this issue
Jan 23, 2019
…same functionality for global styles from Angular CLI ISSUES CLOSED: NationalBankBelgium#1070 BREAKING CHANGE: global styles must be included in the angular.json (standard Angular CLI behavior) instead of importing them directly in the app
christophercr
added a commit
to christophercr/stark
that referenced
this issue
Jan 23, 2019
…same functionality for global styles from Angular CLI ISSUES CLOSED: NationalBankBelgium#1070 BREAKING CHANGE: global styles must be included in the angular.json (standard Angular CLI behavior) instead of importing them directly in the app
christophercr
added a commit
to christophercr/stark
that referenced
this issue
Jan 23, 2019
…same functionality for global styles from Angular CLI ISSUES CLOSED: NationalBankBelgium#1070 BREAKING CHANGE: global styles must be included in the angular.json (standard Angular CLI behavior) instead of importing them directly in the app
christophercr
added a commit
to christophercr/stark
that referenced
this issue
Jan 23, 2019
…l styles from angular.json to align with Angular CLI ISSUES CLOSED: NationalBankBelgium#1070 BREAKING CHANGE: global styles must be included in the angular.json (standard Angular CLI behavior) instead of importing them directly in the app
christophercr
added a commit
to christophercr/stark
that referenced
this issue
Jan 25, 2019
…l styles from angular.json to align with Angular CLI ISSUES CLOSED: NationalBankBelgium#1070 BREAKING CHANGE: global styles must be included in the angular.json (standard Angular CLI behavior) instead of importing them directly in the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a...
Current behavior
In an app generated using the Angular CLI project, the files containing global styles should be included in the
angular.json
file atprojects -> your-app -> architect -> build -> options -> styles
.This way, when using the
ng serve
command, Webpack will build the app including astyles
bundle and add it to the index.html so global styles work as expected.This is not the case when using the stark-build package instead of Angular CLI. Right now the global styles should be directly imported in the
app.module.ts
otherwise Webpack will not include them in the build and it will not create thestyles
bundle for them.Expected behavior
The stark-build should mimic the same functionality for global styles as Angular CLI.
Minimal reproduction of the problem with instructions
src/styles
angular.json
of the app underprojects -> your-app -> architect -> build -> options -> styles
npm start
command.What is the motivation / use case for changing the behavior?
Make stark-build fully compatible (or as much as possible) with Angular CLI by respecting the API in the
angular.json
file.Environment
The text was updated successfully, but these errors were encountered: