Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: icons are not in the middle of buttons #1030

Closed
carlo-nomes opened this issue Jan 11, 2019 · 2 comments · Fixed by #1039
Closed

ui: icons are not in the middle of buttons #1030

carlo-nomes opened this issue Jan 11, 2019 · 2 comments · Fixed by #1039
Labels
comp: stark-ui type: enhancement
Milestone
10.0.0-beta.3

Comments

@carlo-nomes
Copy link
Collaborator

I'm submitting a...


[?] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Depending on the browser the icon is offset from the center.

Expected behavior

The icon is in the middle.

Environment


Angular CLI: 7.2.1
Node: 11.4.0
OS: darwin x64
Angular: 7.1.1


Browser:
- [x] Chrome (desktop) version XX
- [x] Chrome (Android) version XX
- [x] Chrome (iOS) version XX
- [x] Firefox version XX
- [x] Safari (desktop) version XX
- [x] Safari (iOS) version XX
- [x] IE version XX
- [x] Edge version XX

Others:

    "@angular/material": "7.2.0"
@carlo-nomes carlo-nomes self-assigned this Jan 11, 2019
@christophercr christophercr added this to the 10.0.0-beta.3 milestone Jan 14, 2019
@carlo-nomes
Copy link
Collaborator Author

Maybe relate to #504

@carlo-nomes carlo-nomes mentioned this issue Jan 15, 2019
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 15, 2019
@carlo-nomes
fix(stark-demo): fix icons not displaying correctly
37e950c 
  - add StarkSvgViewBoxModule to shared modules
  - offset icon slightly to compensate @angular/material update
  - update icon scaling functionality after correct `starkSvgViewBox` implementation

ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 15, 2019
@carlo-nomes
fix(stark-demo): fix icons not displaying correctly
181ada1 
  - add StarkSvgViewBoxModule to shared modules
  - offset icon slightly to compensate @angular/material update
  - update icon scaling functionality after correct `starkSvgViewBox` implementation

ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 15, 2019
@carlo-nomes
fix(stark-demo): fix icons not displaying correctly
8bd9b4a 
  - add StarkSvgViewBoxModule to shared modules
  - offset icon slightly to compensate @angular/material update
  - update icon scaling functionality after correct `starkSvgViewBox` implementation

ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
@carlo-nomes
Copy link
Collaborator Author

carlo-nomes commented Jan 15, 2019 •
edited
Loading

Example: https://angular-centered-icons-bug.stackblitz.io/
Related: angular/components#8842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: enhancement
Projects
None yet
Milestone
10.0.0-beta.3
Development

Successfully merging a pull request may close this issue.

fix(stark-ui): fix icons not displaying correctly carlo-nomes/stark
2 participants
@christophercr @carlo-nomes