Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: put all styles imports in one file (stark-ui.scss) #103

Closed
dsebastien opened this issue Mar 2, 2018 · 0 comments · Fixed by #1064
Closed

ui: put all styles imports in one file (stark-ui.scss) #103

dsebastien opened this issue Mar 2, 2018 · 0 comments · Fixed by #1064
Labels
comp: stark-ui must type: discussion / RFC
Milestone
10.0.0-beta.3

Comments

@dsebastien
Copy link
Contributor

Goal: get the theme apart to avoid forcing it down on users
@dsebastien dsebastien added this to the should milestone Mar 2, 2018
@SuperITMan SuperITMan changed the title ui: isolate default stark theme ui: put all styles imports in one file (stark-ui.scss) Nov 8, 2018
@SuperITMan SuperITMan modified the milestones: should, 10.0.0-beta.2 Nov 8, 2018
@SuperITMan SuperITMan added must and removed should labels Nov 8, 2018
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 22, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui.scss) to impo…
6b97572 
…rt all `.scss` files needed for stark-ui

  - updated showcase/starter
    - import `stark-ui.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss`
    - remove additional themes

ISSUES CLOSED: NationalBankBelgium#103
@carlo-nomes carlo-nomes mentioned this issue Jan 22, 2019
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 23, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui.scss) to impo…
115e6d4 
…rt all `.scss` files needed for stark-ui

  - updated showcase/starter
    - import `stark-ui.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss`
    - remove additional themes

ISSUES CLOSED: NationalBankBelgium#103
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 23, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui.scss) to impo…
c044abf 
…rt all `.scss` files needed for stark-ui

  - updated showcase/starter
    - import `stark-ui.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss`
    - remove additional themes

ISSUES CLOSED: NationalBankBelgium#103
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 23, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui-bundle.scss) …
fce56e0 
…to import all component styles/theming

  - updated showcase/starter
    - import `stark-ui-bundle.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss` (imported with stark-ui/.../theming)
    - remove additional themes
  - refactor stark-ui/assets/*.scss

ISSUES CLOSED: NationalBankBelgium#103
carlo-nomes added a commit that referenced this issue Jan 23, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui-bundle.scss) …
6226999 
…to import all component styles/theming

  - updated showcase/starter
    - import `stark-ui-bundle.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss` (imported with stark-ui/.../theming)
    - remove additional themes
  - refactor stark-ui/assets/*.scss
  - added documentation

ISSUES CLOSED: #103
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 24, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui-bundle.scss) …
dc9a5c3 
…to import all component styles/theming

  - updated showcase/starter
    - import `stark-ui-bundle.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss` (imported with stark-ui/.../theming)
    - remove additional themes
  - refactor stark-ui/assets/*.scss
  - added documentation

ISSUES CLOSED: NationalBankBelgium#103
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 24, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui-bundle.scss) …
af78629 
…to import all component styles/theming

  - updated showcase/starter
    - import `stark-ui-bundle.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss` (imported with stark-ui/.../theming)
    - remove additional themes
  - refactor stark-ui/assets/*.scss
  - added documentation

ISSUES CLOSED: NationalBankBelgium#103
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 24, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui-bundle.scss) …
cb1a8ee 
…to import all component styles/theming

  - updated showcase/starter
    - import `stark-ui-bundle.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss` (imported with stark-ui/.../theming)
    - remove additional themes
  - refactor stark-ui/assets/*.scss
  - added documentation

ISSUES CLOSED: NationalBankBelgium#103
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 28, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui-bundle.scss) …
304fbda 
…to import all component styles/theming

  - updated showcase/starter
    - import `stark-ui-bundle.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss` (imported with stark-ui/.../theming)
    - remove additional themes
  - refactor stark-ui/assets/*.scss
  - added documentation

ISSUES CLOSED: NationalBankBelgium#103
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 28, 2019
@carlo-nomes
feat(stark-ui): expose single file (src/assets/stark-ui-bundle.scss) …
b86e190 
…to import all component styles/theming

  - updated showcase/starter
    - import `stark-ui-bundle.scss`
    - remove `_stark-styles.scss`
    - remove `~@angular/material/theming` from `_theme.scss` (imported with stark-ui/.../theming)
    - remove additional themes
  - refactor stark-ui/assets/*.scss
  - added documentation

ISSUES CLOSED: NationalBankBelgium#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui must type: discussion / RFC
Projects
None yet
Milestone
10.0.0-beta.3
Development

Successfully merging a pull request may close this issue.

feat(stark-ui): expose single file to import all .scss files needed for stark-ui carlo-nomes/stark
4 participants
@dsebastien @christophercr @SuperITMan @carlo-nomes