fix(stark-build): fix warning messages appearing at build time

Fix TSLint warnings for rules - "no-promise-as-boolean" - "strict-comparisons" Remove temporary fix for Prettier warning Exclude "google-libphonenumber" library from parsing by babel-loader in DEV build
NationalBankBelgium · Mar 9, 2021 · d318519 · d318519
1 parent 7db18b9
commit d318519
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/packages/stark-build/config/tslint-disabled-typecheck-rules.json b/packages/stark-build/config/tslint-disabled-typecheck-rules.json
@@ -23,6 +23,7 @@
     "no-in-misuse": false,
     "no-invalid-await": false,
     "no-null-undefined-union": false,
+    "no-promise-as-boolean": false,
     "no-restricted-globals": false,
     "no-misleading-array-reverse": false,
     "no-redundant-boolean": false,
@@ -49,6 +50,7 @@
     "restrict-plus-operands": false,
     "return-undefined": false,
     "strict-boolean-expressions": false,
+    "strict-comparisons": false,
     "strict-type-predicates": false,
     "unnecessary-bind": false,
     "use-default-type-parameter": false,

diff --git a/packages/stark-build/config/webpack-partial.common.js b/packages/stark-build/config/webpack-partial.common.js
@@ -33,7 +33,7 @@ const fixedTSLintConfig = buildUtils.getFixedTSLintConfig(
  *
  * See: http://webpack.github.io/docs/configuration.html#cli
  */
-module.exports = metadata => {
+module.exports = (metadata) => {
 	const isProd = metadata.ENV === "production";
 	const METADATA = metadata;
 
@@ -72,9 +72,6 @@ module.exports = metadata => {
 		 * See: https://webpack.js.org/configuration/module
 		 */
 		module: {
-			// FIXME Remove the following line once Prettier 2.0.0 is released. See: https://github.com/NationalBankBelgium/stark/issues/1483
-			noParse: /prettier\/parser-typescript/,
-
 			rules: [
 				/**
 				 * TSLint loader support for *.ts files
@@ -145,7 +142,7 @@ module.exports = metadata => {
 			new HtmlWebpackPlugin({
 				template: "!!ejs-loader!src/index.html",
 				title: METADATA.TITLE,
-				chunksSortMode: function(a, b) {
+				chunksSortMode: function (a, b) {
 					// generated entry points will include those from styles config
 					// const entryPoints = ["runtime", "polyfills", "sw-register", "styles", "vendor", "main"];
 					// logic extracted from getBrowserConfig function in @angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/browser.js

diff --git a/packages/stark-build/config/webpack-partial.dev.js b/packages/stark-build/config/webpack-partial.dev.js
@@ -61,7 +61,7 @@ module.exports = webpackMerge(commonConfig(METADATA), {
 			 */
 			{
 				test: /node_modules.*\.js$/,
-				exclude: /node_modules.*(@angular|@mdi|@ng-idle|@nationalbankbelgium|@ngrx|@ngx-translate|@uirouter|cerialize|class-validator|core-js|ibantools|lodash|prettier|rxjs)/,
+				exclude: /node_modules.*(@angular|@mdi|@ng-idle|@nationalbankbelgium|@ngrx|@ngx-translate|@uirouter|cerialize|class-validator|core-js|google-libphonenumber|ibantools|lodash|prettier|rxjs)/,
 				use: {
 					loader: "babel-loader",
 					options: {