feat(stark-ui): refactor tests due to change in angular 16

- The option `entryComponent` has been removed in `@NgModule` - Fix issue with mutiple calls in input-mask-directives
NationalBankBelgium · Jun 3, 2024 · 3ef970f · 3ef970f
1 parent c1b9881
commit 3ef970f
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 96 deletions.
diff --git a/packages/stark-ui/src/modules/dialogs/components/alert-dialog.component.spec.ts b/packages/stark-ui/src/modules/dialogs/components/alert-dialog.component.spec.ts
@@ -10,7 +10,6 @@ import {
 import { MatIconModule } from "@angular/material/icon";
 import { MatIconTestingModule } from "@angular/material/icon/testing";
 import { NoopAnimationsModule } from "@angular/platform-browser/animations";
-import { BrowserDynamicTestingModule } from "@angular/platform-browser-dynamic/testing";
 import { OverlayContainer } from "@angular/cdk/overlay";
 import { ESCAPE } from "@angular/cdk/keycodes";
 import { TranslateModule } from "@ngx-translate/core";
@@ -74,13 +73,7 @@ describe("AlertDialogComponent", () => {
 			declarations: [TestHostComponent, StarkAlertDialogComponent],
 			imports: [CommonModule, NoopAnimationsModule, MatDialogModule, MatIconModule, MatIconTestingModule, TranslateModule.forRoot()],
 			providers: []
-		})
-			.overrideModule(BrowserDynamicTestingModule, {
-				// FIXME review after https://github.com/angular/angular/issues/10760
-				// add entryComponent to TestingModule (suggested in https://github.com/angular/angular/issues/10760#issuecomment-250522300)
-				set: { entryComponents: [StarkAlertDialogComponent] }
-			})
-			.compileComponents()));
+		}).compileComponents()));
 
 	beforeEach(inject(
 		[MatDialog, OverlayContainer, ComponentFactoryResolver],

diff --git a/packages/stark-ui/src/modules/dialogs/components/confirm-dialog.component.spec.ts b/packages/stark-ui/src/modules/dialogs/components/confirm-dialog.component.spec.ts
@@ -8,7 +8,6 @@ import {
 	MatLegacyDialogRef as MatDialogRef
 } from "@angular/material/legacy-dialog";
 import { NoopAnimationsModule } from "@angular/platform-browser/animations";
-import { BrowserDynamicTestingModule } from "@angular/platform-browser-dynamic/testing";
 import { OverlayContainer } from "@angular/cdk/overlay";
 import { ESCAPE } from "@angular/cdk/keycodes";
 import { TranslateModule } from "@ngx-translate/core";
@@ -76,13 +75,7 @@ describe("ConfirmDialogComponent", () => {
 			declarations: [TestHostComponent, StarkConfirmDialogComponent],
 			imports: [CommonModule, NoopAnimationsModule, MatDialogModule, TranslateModule.forRoot()],
 			providers: []
-		})
-			.overrideModule(BrowserDynamicTestingModule, {
-				// FIXME review after https://github.com/angular/angular/issues/10760
-				// add entryComponent to TestingModule (suggested in https://github.com/angular/angular/issues/10760#issuecomment-250522300)
-				set: { entryComponents: [StarkConfirmDialogComponent] }
-			})
-			.compileComponents()));
+		}).compileComponents()));
 
 	beforeEach(inject(
 		[MatDialog, OverlayContainer, ComponentFactoryResolver],

diff --git a/packages/stark-ui/src/modules/dialogs/components/prompt-dialog.component.spec.ts b/packages/stark-ui/src/modules/dialogs/components/prompt-dialog.component.spec.ts
@@ -10,7 +10,6 @@ import {
 } from "@angular/material/legacy-dialog";
 import { MatLegacyInputModule as MatInputModule } from "@angular/material/legacy-input";
 import { NoopAnimationsModule } from "@angular/platform-browser/animations";
-import { BrowserDynamicTestingModule } from "@angular/platform-browser-dynamic/testing";
 import { OverlayContainer } from "@angular/cdk/overlay";
 import { ESCAPE } from "@angular/cdk/keycodes";
 import { TranslateModule } from "@ngx-translate/core";
@@ -81,13 +80,7 @@ describe("PromptDialogComponent", () => {
 			declarations: [TestHostComponent, StarkPromptDialogComponent],
 			imports: [CommonModule, ReactiveFormsModule, NoopAnimationsModule, MatInputModule, MatDialogModule, TranslateModule.forRoot()],
 			providers: []
-		})
-			.overrideModule(BrowserDynamicTestingModule, {
-				// FIXME review after https://github.com/angular/angular/issues/10760
-				// add entryComponent to TestingModule (suggested in https://github.com/angular/angular/issues/10760#issuecomment-250522300)
-				set: { entryComponents: [StarkPromptDialogComponent] }
-			})
-			.compileComponents()));
+		}).compileComponents()));
 
 	beforeEach(inject(
 		[MatDialog, OverlayContainer, ComponentFactoryResolver],

diff --git a/packages/stark-ui/src/modules/input-mask-directives/directives/email-mask.directive.spec.ts b/packages/stark-ui/src/modules/input-mask-directives/directives/email-mask.directive.spec.ts
@@ -259,16 +259,14 @@ describe("EmailMaskDirective", () => {
 				changeInputValue(inputElement, "");
 				fixture.detectChanges();
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 				mockValueChangeObserver.next.calls.reset();
 				changeInputValue(inputElement, "my-email@", eventType);
 				fixture.detectChanges();
 
 				expect(hostComponent.formControl.value).toBe("my-email@ .");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 				expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 				expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 			}
@@ -280,8 +278,7 @@ describe("EmailMaskDirective", () => {
 				changeInputValue(inputElement, "");
 				fixture.detectChanges();
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 				mockValueChangeObserver.next.calls.reset();
 				changeInputValue(inputElement, "my-email@", eventType);
@@ -304,8 +301,7 @@ describe("EmailMaskDirective", () => {
 				fixture.detectChanges();
 
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 				expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 				expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 			}
@@ -316,8 +312,7 @@ describe("EmailMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("my-email@ .");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.emailMaskConfig = undefined;
@@ -329,8 +324,7 @@ describe("EmailMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("my-email@ ."); // the mask is enabled by default
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.emailMaskConfig = ""; // use case when the directive is used with no inputs: <input type='text' [formControl]='formControl' starkEmailMask>
@@ -342,8 +336,7 @@ describe("EmailMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("my-email@ ."); // the mask is enabled by default
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.emailMaskConfig = false;
@@ -355,8 +348,7 @@ describe("EmailMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("what@@.ever@."); // no mask at all
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 			expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 			expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 		});

diff --git a/packages/stark-ui/src/modules/input-mask-directives/directives/number-mask.directive.spec.ts b/packages/stark-ui/src/modules/input-mask-directives/directives/number-mask.directive.spec.ts
@@ -275,16 +275,14 @@ describe("NumberMaskDirective", () => {
 				changeInputValue(inputElement, "");
 				fixture.detectChanges();
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 				mockValueChangeObserver.next.calls.reset();
 				changeInputValue(inputElement, "12345", eventType);
 				fixture.detectChanges();
 
 				expect(hostComponent.formControl.value).toBe("12,345");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 				expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 				expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 			}
@@ -296,8 +294,7 @@ describe("NumberMaskDirective", () => {
 				changeInputValue(inputElement, "");
 				fixture.detectChanges();
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 				mockValueChangeObserver.next.calls.reset();
 				changeInputValue(inputElement, "12345", eventType);
@@ -320,8 +317,7 @@ describe("NumberMaskDirective", () => {
 				fixture.detectChanges();
 
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 				expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 				expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 			}
@@ -334,8 +330,7 @@ describe("NumberMaskDirective", () => {
 				fixture.detectChanges();
 
 				expect(hostComponent.formControl.value).toBe("12,345");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 				expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 				expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 			}
@@ -346,16 +341,14 @@ describe("NumberMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("12,345");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.numberMaskConfig = { ...numberMaskConfig, prefix: "%", suffix: " percent", thousandsSeparatorSymbol: "-" };
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("%12-345 percent");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 			expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 			expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 		});
@@ -365,8 +358,7 @@ describe("NumberMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("12,345");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.numberMaskConfig = <any>undefined;
@@ -378,8 +370,7 @@ describe("NumberMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("whatever+1*23-4/5"); // no mask at all
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 			expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 			expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 		});

diff --git a/packages/stark-ui/src/modules/input-mask-directives/directives/text-mask.directive.spec.ts b/packages/stark-ui/src/modules/input-mask-directives/directives/text-mask.directive.spec.ts
@@ -297,16 +297,14 @@ describe("TextMaskDirective", () => {
 				changeInputValue(inputElement, "");
 				fixture.detectChanges();
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 				mockValueChangeObserver.next.calls.reset();
 				changeInputValue(inputElement, "123", eventType);
 				fixture.detectChanges();
 
 				expect(hostComponent.formControl.value).toBe("12/3_");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 				expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 				expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 			}
@@ -318,8 +316,7 @@ describe("TextMaskDirective", () => {
 				changeInputValue(inputElement, "");
 				fixture.detectChanges();
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 				mockValueChangeObserver.next.calls.reset();
 				changeInputValue(inputElement, "123", eventType);
@@ -342,8 +339,7 @@ describe("TextMaskDirective", () => {
 				fixture.detectChanges();
 
 				expect(hostComponent.formControl.value).toBe("");
-				// FIXME Check why it is called twice instead of once
-				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+				expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 				expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 				expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 			}
@@ -354,16 +350,14 @@ describe("TextMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("12/3_");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.textMaskConfig = { ...textMaskConfig, mask: [/\d/, "/", /\d/, "/", /\d/, /\d/], placeholderChar: "-" };
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("1/2/3-");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 			expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 			expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 		});
@@ -373,16 +367,14 @@ describe("TextMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("12/3_");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.textMaskConfig = { ...textMaskConfig, guide: false };
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("12/3");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 			expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 			expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 		});
@@ -392,8 +384,7 @@ describe("TextMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("12/3_");
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.textMaskConfig = <any>undefined;
@@ -405,8 +396,7 @@ describe("TextMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("whatever"); // no mask at all
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 
 			mockValueChangeObserver.next.calls.reset();
 			hostComponent.textMaskConfig = { mask: false };
@@ -418,8 +408,7 @@ describe("TextMaskDirective", () => {
 			fixture.detectChanges();
 
 			expect(hostComponent.formControl.value).toBe("123"); // no mask at all
-			// FIXME Check why it is called twice instead of once
-			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(2);
+			expect(mockValueChangeObserver.next).toHaveBeenCalledTimes(1);
 			expect(mockValueChangeObserver.error).not.toHaveBeenCalled();
 			expect(mockValueChangeObserver.complete).not.toHaveBeenCalled();
 		});