Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Time Interface File #2579

Closed
LeStarch opened this issue Mar 12, 2024 · 5 comments
Closed

Rename Time Interface File #2579

LeStarch opened this issue Mar 12, 2024 · 5 comments
Labels
bug Easy First Issue An issue that should be straight forward to implement, and easily tested via CI. Medium Priority Update Instructions Needed Need to add instructions in the release notes for updates.
Milestone
Release v3.5.0

Comments

@LeStarch
Copy link
Collaborator

F´ Version
Affected Component

Problem Description

Svc/Interfaces/Time.fppi should be renamed to Svc/Interfaces/TimeInterface.fppi to match modern standards.
@LeStarch LeStarch added the bug label Mar 12, 2024
@LeStarch LeStarch mentioned this issue Mar 12, 2024
Open
10 tasks
@LeStarch LeStarch added Medium Priority Easy First Issue An issue that should be straight forward to implement, and easily tested via CI. labels Mar 27, 2024
@rldettloff
Copy link
Contributor

I'm working on this!

@LeStarch
Copy link
Collaborator Author

@rldettloff are you still working on this?

@LeStarch LeStarch added the Update Instructions Needed Need to add instructions in the release notes for updates. label May 10, 2024
@LeStarch LeStarch added this to the Release v3.5.0 milestone May 10, 2024
@CombustableLem0n
Copy link
Contributor

I added a pull request addressing this issue. I'm new to submitting pull requests but I think this should help you find my pull request. (gh pr checkout 2728)

@thomas-bc thomas-bc mentioned this issue May 13, 2024
Merged
@CombustableLem0n
Copy link
Contributor

I'm confused why some test checks failed first time on my pull request, but the same checks passed second with identical code. Any explanations?

@thomas-bc
Copy link
Collaborator

@CombustableLem0n thank you for closing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Easy First Issue An issue that should be straight forward to implement, and easily tested via CI. Medium Priority Update Instructions Needed Need to add instructions in the release notes for updates.
Projects
None yet
Milestone
Release v3.5.0
Development

No branches or pull requests
4 participants
@LeStarch @thomas-bc @rldettloff @CombustableLem0n