From 56217a3ed59ef1d6cc6a30855156049b7977e75a Mon Sep 17 00:00:00 2001 From: M Starch Date: Thu, 2 Sep 2021 10:10:37 -0700 Subject: [PATCH] lestarch: fixing .start in UTs, docs, templates --- .../topology/publicInstanceTopologyCpp.tmpl | 2 +- .../templates/topology/publicTopologyCpp.tmpl | 2 +- .../visitors/InstanceTopologyCppVisitor.py | 4 +- .../visitors/InstanceTopologyHVisitor.py | 4 +- .../generators/visitors/TopologyCppVisitor.py | 4 +- .../generators/visitors/TopologyHVisitor.py | 4 +- Autocoders/Python/test/app1/DuckAppAcRef.cpp | 6 +-- Autocoders/Python/test/app1/ReadMe | 21 --------- Autocoders/Python/test/app1/scons.log | 46 ------------------- Autocoders/Python/test/app2/Top.cpp | 6 +-- Autocoders/Python/test/app2/test/ut/Top.cpp | 6 +-- Autocoders/Python/test/app4/app2AppAcRef.cpp | 4 +- Autocoders/Python/test/cnt_only/Top.cpp | 4 +- .../Python/test/cnt_only/test/ut/Top.cpp | 4 +- .../Python/test/command_string/main.cpp | 2 +- Autocoders/Python/test/partition/Top.cpp | 4 +- Autocoders/Python/test/passive/Top.cpp | 4 +- .../test/serial_passive/test/ut/main.cpp | 2 +- .../Python/test/serialize_template/main.cpp | 2 +- .../Python/test/serialize_user/main.cpp | 2 +- Autocoders/Python/test/stress/main.cpp | 2 +- Drv/Ip/SocketReadTask.cpp | 2 +- Fw/Comp/ActiveComponentBase.cpp | 3 +- Os/test/ut/OsTaskTest.cpp | 2 +- Utils/test/ut/LockGuardTester.cpp | 2 +- docs/Tutorials/MathComponent/Tutorial.md | 13 ++---- 26 files changed, 41 insertions(+), 116 deletions(-) delete mode 100644 Autocoders/Python/test/app1/ReadMe delete mode 100644 Autocoders/Python/test/app1/scons.log diff --git a/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicInstanceTopologyCpp.tmpl b/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicInstanceTopologyCpp.tmpl index 981de7ed4b8..5b9bfc48743 100644 --- a/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicInstanceTopologyCpp.tmpl +++ b/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicInstanceTopologyCpp.tmpl @@ -43,7 +43,7 @@ void $(name)Init(void) { void $(name)Start(void) { // Active component startup - // start(identifier, priority, stack_size) + // start() #for $startup_template in $component_startups: ${startup_template} #end for diff --git a/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicTopologyCpp.tmpl b/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicTopologyCpp.tmpl index 514a4cd9356..0c6318d4953 100644 --- a/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicTopologyCpp.tmpl +++ b/Autocoders/Python/src/fprime_ac/generators/templates/topology/publicTopologyCpp.tmpl @@ -44,7 +44,7 @@ void construct$(name)Architecture(void) { #else: ### // Active component startup - // start(identifier, priority, stack_size) + // start() #for $startup_template in $component_startups: ${startup_template} #end for diff --git a/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyCppVisitor.py b/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyCppVisitor.py index 72f0099ad15..69810b348c3 100644 --- a/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyCppVisitor.py +++ b/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyCppVisitor.py @@ -382,10 +382,10 @@ def publicVisit(self, obj): if component["kind"] == "active": if obj.is_ptr: startup_template = ( - """{name}_ptr->start(0, 100, 10 * 1024);""".format(**component) + """{name}_ptr->start();""".format(**component) ) else: - startup_template = """{name}.start(0, 100, 10 * 1024);""".format( + startup_template = """{name}.start();""".format( **component ) c.component_startups.append(startup_template) diff --git a/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyHVisitor.py b/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyHVisitor.py index fec716023eb..8cc5ab6b260 100644 --- a/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyHVisitor.py +++ b/Autocoders/Python/src/fprime_ac/generators/visitors/InstanceTopologyHVisitor.py @@ -389,10 +389,10 @@ def publicVisit(self, obj): if component["kind"] == "active": if obj.is_ptr: startup_template = ( - """{name}_ptr->start(0, 100, 10 * 1024);""".format(**component) + """{name}_ptr->start();""".format(**component) ) else: - startup_template = """{name}.start(0, 100, 10 * 1024);""".format( + startup_template = """{name}.start();""".format( **component ) c.component_startups.append(startup_template) diff --git a/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyCppVisitor.py b/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyCppVisitor.py index faeb25e6c55..7d287ed8353 100644 --- a/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyCppVisitor.py +++ b/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyCppVisitor.py @@ -380,10 +380,10 @@ def publicVisit(self, obj): if component["kind"] == "active": if obj.is_ptr: startup_template = ( - """{name}_ptr->start(0, 100, 10 * 1024);""".format(**component) + """{name}_ptr->start();""".format(**component) ) else: - startup_template = """{name}.start(0, 100, 10 * 1024);""".format( + startup_template = """{name}.start();""".format( **component ) c.component_startups.append(startup_template) diff --git a/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyHVisitor.py b/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyHVisitor.py index de5683facb1..72bd41b0c40 100644 --- a/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyHVisitor.py +++ b/Autocoders/Python/src/fprime_ac/generators/visitors/TopologyHVisitor.py @@ -390,10 +390,10 @@ def publicVisit(self, obj): if component["kind"] == "active": if obj.is_ptr: startup_template = ( - """{name}_ptr->start(0, 100, 10 * 1024);""".format(**component) + """{name}_ptr->start();""".format(**component) ) else: - startup_template = """{name}.start(0, 100, 10 * 1024);""".format( + startup_template = """{name}.start();""".format( **component ) c.component_startups.append(startup_template) diff --git a/Autocoders/Python/test/app1/DuckAppAcRef.cpp b/Autocoders/Python/test/app1/DuckAppAcRef.cpp index c243c74bee5..5d231288b51 100644 --- a/Autocoders/Python/test/app1/DuckAppAcRef.cpp +++ b/Autocoders/Python/test/app1/DuckAppAcRef.cpp @@ -49,9 +49,9 @@ void constructArchitecture(void) { // Active component startup - // start(identifier, stack size, priority) - hueyComp_ptr->start(0, 10 * 1024, 100); - dueyComp_ptr->start(0, 10 * 1024, 100); + // start() + hueyComp_ptr->start(); + dueyComp_ptr->start(); dumparch(); } diff --git a/Autocoders/Python/test/app1/ReadMe b/Autocoders/Python/test/app1/ReadMe deleted file mode 100644 index b5badad5926..00000000000 --- a/Autocoders/Python/test/app1/ReadMe +++ /dev/null @@ -1,21 +0,0 @@ -Date: 24 Apr. 2013 - -This is the huey/duey two active component -test case. Currently builds with -make and make ut...executes via the Top executable -located in test/ut. - - -To run this test: - -run: - - nosetests - -OR - -run: - - make - make ut - make run_ut diff --git a/Autocoders/Python/test/app1/scons.log b/Autocoders/Python/test/app1/scons.log deleted file mode 100644 index 24ca32e0a33..00000000000 --- a/Autocoders/Python/test/app1/scons.log +++ /dev/null @@ -1,46 +0,0 @@ -scons: Reading SConscript files ... -scons: done reading SConscript files. -scons: Building targets ... -g++ -o DuckAppAcRef.o -c -I/home/reder/src/isf -I/home/reder/src/isf/Fw/Types/Linux DuckAppAcRef.cpp -g++ -o DuckDuckComponentAc.o -c -I/home/reder/src/isf -I/home/reder/src/isf/Fw/Types/Linux DuckDuckComponentAc.cpp -g++ -o DuckDuckImpl.o -c -I/home/reder/src/isf -I/home/reder/src/isf/Fw/Types/Linux DuckDuckImpl.cpp -g++ -o Msg1PortAc.o -c -I/home/reder/src/isf -I/home/reder/src/isf/Fw/Types/Linux Msg1PortAc.cpp -g++ -o Top.o -c -I/home/reder/src/isf -I/home/reder/src/isf/Fw/Types/Linux Top.cpp -g++ -o Top DuckDuckComponentAc.o DuckDuckImpl.o Msg1PortAc.o DuckAppAcRef.o Top.o -L/home/reder/src/isf/FswScons/linux/Os -L/home/reder/src/isf/FswScons/linux/Fw/Comp -L/home/reder/src/isf/FswScons/linux/Fw/Obj -L/home/reder/src/isf/FswScons/linux/Fw/Port -L/home/reder/src/isf/FswScons/linux/Fw/Types -lOs -lFwComp -lFwObj -lFwPort -lFwTypes -lpthread -lrt -/home/reder/src/isf/FswScons/linux/Os/libOs.a: In function `~Queue': -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:75: undefined reference to `Os::QueueString::toChar() const' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:77: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:77: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:75: undefined reference to `Os::QueueString::toChar() const' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:77: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:77: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:75: undefined reference to `Os::QueueString::toChar() const' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:77: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:77: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/FswScons/linux/Os/libOs.a: In function `Os::Queue::create(Fw::StringBase const&, int, int, Os::Queue::QueueBlocking)': -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:28: undefined reference to `Os::QueueString::QueueString(char const*)' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:28: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:28: undefined reference to `Os::QueueString::~QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:46: undefined reference to `Os::QueueString::toChar() const' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:52: undefined reference to `Os::QueueString::toChar() const' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:58: undefined reference to `Os::QueueString::toChar() const' -/home/reder/src/isf/FswScons/linux/Os/libOs.a: In function `Queue': -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:22: undefined reference to `Os::QueueString::QueueString()' -/home/reder/src/isf/Os/Posix/OsQueuePosix.cpp:22: undefined reference to `Os::QueueString::QueueString()' -/home/reder/src/isf/FswScons/linux/Os/libOs.a: In function `~Task': -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:175: undefined reference to `Os::TaskString::~TaskString()' -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:175: undefined reference to `Os::TaskString::~TaskString()' -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:175: undefined reference to `Os::TaskString::~TaskString()' -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:175: undefined reference to `Os::TaskString::~TaskString()' -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:175: undefined reference to `Os::TaskString::~TaskString()' -/home/reder/src/isf/FswScons/linux/Os/libOs.a:/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:175: more undefined references to `Os::TaskString::~TaskString()' follow -/home/reder/src/isf/FswScons/linux/Os/libOs.a: In function `Os::Task::start(Fw::StringBase const&, int, int, int, void (*)(void*), void*, int)': -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:33: undefined reference to `Os::TaskString::TaskString(char const*)' -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:33: undefined reference to `Os::TaskString::~TaskString()' -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:33: undefined reference to `Os::TaskString::~TaskString()' -/home/reder/src/isf/FswScons/linux/Os/libOs.a: In function `Task': -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:28: undefined reference to `Os::TaskString::TaskString()' -/home/reder/src/isf/Os/Posix/OsTaskPosix.cpp:28: undefined reference to `Os::TaskString::TaskString()' -collect2: ld returned 1 exit status -scons: *** [Top] Error 1 -scons: building terminated because of errors. diff --git a/Autocoders/Python/test/app2/Top.cpp b/Autocoders/Python/test/app2/Top.cpp index 7667563e8d3..12b345d4f70 100644 --- a/Autocoders/Python/test/app2/Top.cpp +++ b/Autocoders/Python/test/app2/Top.cpp @@ -55,9 +55,9 @@ void constructArchitecture(void) { // Active component startup - // start(identifier, stack size, priority) - C1_ptr->start(0, 10 * 1024, 100); - C2_ptr->start(0, 10 * 1024, 100); + // start() + C1_ptr->start(); + C2_ptr->start(); dumparch(); diff --git a/Autocoders/Python/test/app2/test/ut/Top.cpp b/Autocoders/Python/test/app2/test/ut/Top.cpp index 7667563e8d3..12b345d4f70 100644 --- a/Autocoders/Python/test/app2/test/ut/Top.cpp +++ b/Autocoders/Python/test/app2/test/ut/Top.cpp @@ -55,9 +55,9 @@ void constructArchitecture(void) { // Active component startup - // start(identifier, stack size, priority) - C1_ptr->start(0, 10 * 1024, 100); - C2_ptr->start(0, 10 * 1024, 100); + // start() + C1_ptr->start(); + C2_ptr->start(); dumparch(); diff --git a/Autocoders/Python/test/app4/app2AppAcRef.cpp b/Autocoders/Python/test/app4/app2AppAcRef.cpp index da90d26b528..b5a3b8be23b 100644 --- a/Autocoders/Python/test/app4/app2AppAcRef.cpp +++ b/Autocoders/Python/test/app4/app2AppAcRef.cpp @@ -52,8 +52,8 @@ void constructArchitecture(void) { hueyComp_ptr->setoutputPort2Msg1OutputPort(0, hub1Comp_ptr->getinputPort2SerializeInputPort(0)); // Active component startup - // start(identifier, stack size, priority) - hueyComp_ptr->start(0, 10 * 1024, 100); + // start() + hueyComp_ptr->start(); dumparch(); } diff --git a/Autocoders/Python/test/cnt_only/Top.cpp b/Autocoders/Python/test/cnt_only/Top.cpp index 122ebe514fa..d148df47c6a 100644 --- a/Autocoders/Python/test/cnt_only/Top.cpp +++ b/Autocoders/Python/test/cnt_only/Top.cpp @@ -36,8 +36,8 @@ int main(int argc, char* argv[]) { constructArchitecture(); //Start Components - Huey_ptr->start(0, 10 * 1024, 100); - Duey_ptr->start(0, 10 * 1024, 100); + Huey_ptr->start(); + Duey_ptr->start(); // Ask for input to huey or duey here. char in[80]; diff --git a/Autocoders/Python/test/cnt_only/test/ut/Top.cpp b/Autocoders/Python/test/cnt_only/test/ut/Top.cpp index aab2ab29288..d58b5f6702d 100644 --- a/Autocoders/Python/test/cnt_only/test/ut/Top.cpp +++ b/Autocoders/Python/test/cnt_only/test/ut/Top.cpp @@ -37,8 +37,8 @@ int main(int argc, char* argv[]) { constructDuckArchitecture(); //Start Components - Huey.start(0, 10 * 1024, 100); - Duey.start(0, 10 * 1024, 100); + Huey.start(); + Duey.start(); // Ask for input to huey or duey here. char in[80]; diff --git a/Autocoders/Python/test/command_string/main.cpp b/Autocoders/Python/test/command_string/main.cpp index b8a0fcbb939..a7d20407d7d 100644 --- a/Autocoders/Python/test/command_string/main.cpp +++ b/Autocoders/Python/test/command_string/main.cpp @@ -14,7 +14,7 @@ int main(int argc, char* argv[]) { TestCommand1Impl testImpl("TestCmdImpl"); testImpl.init(10); - testImpl.start(10,10*1024,100); + testImpl.start(); TestCommandSourceImpl cmdSrc("TestCmdSource"); cmdSrc.init(); diff --git a/Autocoders/Python/test/partition/Top.cpp b/Autocoders/Python/test/partition/Top.cpp index d2fc7803bb9..86f0a6266ec 100644 --- a/Autocoders/Python/test/partition/Top.cpp +++ b/Autocoders/Python/test/partition/Top.cpp @@ -66,8 +66,8 @@ void constructArchitecture(void) { partitionComp_ptr->getoutputPort2SerializeOutputPort()->registerSerialPort(hueyComp_ptr->getinputPort3Msg3InputPort()); // Active component startup - // start(identifier, stack size, priority) - hueyComp_ptr->start(0, 10 * 1024, 100); + // start() + hueyComp_ptr->start(); dumparch(); diff --git a/Autocoders/Python/test/passive/Top.cpp b/Autocoders/Python/test/passive/Top.cpp index 200876196ca..ab47aec9f4d 100644 --- a/Autocoders/Python/test/passive/Top.cpp +++ b/Autocoders/Python/test/passive/Top.cpp @@ -51,8 +51,8 @@ void constructArchitecture(void) { // Active component startup - // start(identifier, stack size, priority) - C1_ptr->start(0, 10 * 1024, 100); + // start() + C1_ptr->start(); dumparch(); } diff --git a/Autocoders/Python/test/serial_passive/test/ut/main.cpp b/Autocoders/Python/test/serial_passive/test/ut/main.cpp index 2bc3d931788..303fe0fdc11 100644 --- a/Autocoders/Python/test/serial_passive/test/ut/main.cpp +++ b/Autocoders/Python/test/serial_passive/test/ut/main.cpp @@ -7,7 +7,7 @@ int main(int argc, char* argv[]) { serImpl.init(10,100); ExampleComponents::ExampleComponentImpl exImpl("ExImpl"); exImpl.init(); - serImpl.start(100,100,10*1024); + serImpl.start(); // connect ports exImpl.set_exampleOutput_OutputPort(0,serImpl.get_SerialInSync_InputPort(0)); diff --git a/Autocoders/Python/test/serialize_template/main.cpp b/Autocoders/Python/test/serialize_template/main.cpp index 0ea4c28901a..a2d5c83c3ca 100644 --- a/Autocoders/Python/test/serialize_template/main.cpp +++ b/Autocoders/Python/test/serialize_template/main.cpp @@ -27,7 +27,7 @@ int main(int argc, char* argv[]) { #endif comp.init(10); - comp.start(10, 10 * 1024, 100); + comp.start(); AnotherExample::InputExamplePort* port = comp.getexampleInputExampleInputPort(0); diff --git a/Autocoders/Python/test/serialize_user/main.cpp b/Autocoders/Python/test/serialize_user/main.cpp index 3e24f66cd8d..567e8ad4eba 100644 --- a/Autocoders/Python/test/serialize_user/main.cpp +++ b/Autocoders/Python/test/serialize_user/main.cpp @@ -24,7 +24,7 @@ int main(int argc, char* argv[]) { #endif comp.init(10); - comp.start(10, 10 * 1024, 100); + comp.start(); AnotherExample::InputExamplePort* port = comp.get_exampleInput_InputPort(0); diff --git a/Autocoders/Python/test/stress/main.cpp b/Autocoders/Python/test/stress/main.cpp index 8245c76d6f9..b511c24ee1f 100644 --- a/Autocoders/Python/test/stress/main.cpp +++ b/Autocoders/Python/test/stress/main.cpp @@ -27,7 +27,7 @@ int main(int argc, char* argv[]) { ; #endif testImpl.init(10); - testImpl.start(10, 10 * 1024, 100); + testImpl.start(); TestCommandSourceImpl cmdSrc #if FW_OBJECT_NAMES diff --git a/Drv/Ip/SocketReadTask.cpp b/Drv/Ip/SocketReadTask.cpp index 01756864104..e34165f6c89 100644 --- a/Drv/Ip/SocketReadTask.cpp +++ b/Drv/Ip/SocketReadTask.cpp @@ -32,7 +32,7 @@ void SocketReadTask::startSocketTask(const Fw::StringBase &name, FW_ASSERT(not this->m_stop); // It is a coding error to stop the thread before it is started m_reconnect = reconnect; // Note: the first step is for the IP socket to open the the port - Os::Task::TaskStatus stat = m_task.start(name, SocketReadTask::readTask, this, priority, stack, cpuAffinity, 0); + Os::Task::TaskStatus stat = m_task.start(name, SocketReadTask::readTask, this, priority, stack, cpuAffinity); FW_ASSERT(Os::Task::TASK_OK == stat, static_cast(stat)); } diff --git a/Fw/Comp/ActiveComponentBase.cpp b/Fw/Comp/ActiveComponentBase.cpp index c8984c5afd5..63db128171c 100644 --- a/Fw/Comp/ActiveComponentBase.cpp +++ b/Fw/Comp/ActiveComponentBase.cpp @@ -55,8 +55,7 @@ namespace Fw { static_cast(identifier)); } - void ActiveComponentBase::start(NATIVE_UINT_TYPE priority_in, NATIVE_UINT_TYPE stackSize, NATIVE_UINT_TYPE cpuAffinity, NATIVE_UINT_TYPE identifier) { - NATIVE_INT_TYPE priority = static_cast(priority_in); + void ActiveComponentBase::start(NATIVE_UINT_TYPE priority, NATIVE_UINT_TYPE stackSize, NATIVE_UINT_TYPE cpuAffinity, NATIVE_UINT_TYPE identifier) { Os::TaskString taskName; #if FW_OBJECT_NAMES == 1 diff --git a/Os/test/ut/OsTaskTest.cpp b/Os/test/ut/OsTaskTest.cpp index 8f5e9139b8d..d8be49eb14d 100644 --- a/Os/test/ut/OsTaskTest.cpp +++ b/Os/test/ut/OsTaskTest.cpp @@ -22,6 +22,6 @@ void startTestTask(int iters) { long localIter = iters; testTask = new Os::Task(); Os::TaskString name("ATestTask"); - Os::Task::TaskStatus stat = testTask->start(name,12,100,10*1024,someTask,(void*) localIter); + Os::Task::TaskStatus stat = testTask->start(name, someTask, (void*)localIter); ASSERT_EQ(stat, Os::Task::TASK_OK); } diff --git a/Utils/test/ut/LockGuardTester.cpp b/Utils/test/ut/LockGuardTester.cpp index 132741a730c..068ba5af1fa 100644 --- a/Utils/test/ut/LockGuardTester.cpp +++ b/Utils/test/ut/LockGuardTester.cpp @@ -58,7 +58,7 @@ namespace Utils { { LockGuard guard(data.mutex); - stat = testTask.start(name,12,100,10*1024,taskMethod,(void*) &data); + stat = testTask.start(name, taskMethod, (void*) &data); ASSERT_EQ(stat, Os::Task::TASK_OK); Os::Task::delay(100); ASSERT_EQ(data.i, 0); diff --git a/docs/Tutorials/MathComponent/Tutorial.md b/docs/Tutorials/MathComponent/Tutorial.md index 9432be32037..5f3266688c1 100644 --- a/docs/Tutorials/MathComponent/Tutorial.md +++ b/docs/Tutorials/MathComponent/Tutorial.md @@ -1871,19 +1871,12 @@ The thread for the active `MathSender` component needs to be started: `Ref/Top/Topology.cpp`, line 357: ```c++ - pingRcvr.start(0, 100, 10*1024); + pingRcvr.start(); - mathSender.start(0,100,10*1024); + mathSender.start(); ``` -The arguments to the `start()` function is as follows: - -|Argument|Usage| -|---|---| -|1|Thread ID, unique value for each thread. Not used for Linux| -|2|Thread priority. Passed to underlying OS| -|3|Thread stack size. Passed to underlying OS| - +The start call without arguments uses the Os defaults for priority, stack size, etc. The `MathReceiver` queued component will execute on the thread of the 1Hz rate group, which will be shown later. It does not need to to have a thread started, since queued components do not have threads.