-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If css containes a style without semicolon, building fails #4
Comments
Is there a specific reason not to put a semicolon in the end of the declaration? Or it's just a matter of preference? Testing for presence of semicolon to figure out if it's a selector or declaration is the easiest. Because we assume that if you use preprocessor it will output a valid css with semicolons. E.g in some build configs resulting css selectors are split into multiple lines which means we can't test for |
It should be possible to not put semicolon as it is valid CSS. Specs says that is is not a "line end" I think the origin of this issue produces also the bug below. Source Result
|
how deal with it? |
Try to put background image as a last style in a rule but without a semicolon delimiter. This is valid CSS. The last semicolon is optional in the last line of the CSS rule. But this brakes building with
react-scoped-styles
. The issue doesn't apear if semicolon is always present. Can't be reproduced if the last line doesn't containurl(...)
function.Seems like an issue with regular expression.
The text was updated successfully, but these errors were encountered: