diff --git a/findbugs.xml b/findbugs.xml new file mode 100644 index 00000000000..18fba5c9a9b --- /dev/null +++ b/findbugs.xml @@ -0,0 +1,23 @@ + + + + + + + + + + + + + + + + + + + + + + + diff --git a/pom.xml b/pom.xml index 46681661fe0..33b3a809278 100644 --- a/pom.xml +++ b/pom.xml @@ -314,6 +314,9 @@ org.codehaus.mojo findbugs-maven-plugin 3.0.5 + + findbugs.xml + maven-pmd-plugin diff --git a/src/org/traccar/protocol/MeitrackProtocolDecoder.java b/src/org/traccar/protocol/MeitrackProtocolDecoder.java index 3de71fa1454..b0195d09fba 100644 --- a/src/org/traccar/protocol/MeitrackProtocolDecoder.java +++ b/src/org/traccar/protocol/MeitrackProtocolDecoder.java @@ -242,13 +242,14 @@ private Position decodeRegular(Channel channel, SocketAddress remoteAddress, Cha } if (parser.hasNext(2)) { - decodeDataFields(position, parser.nextInt(), parser.next().split(",")); + parser.nextInt(); // count + decodeDataFields(position, parser.next().split(",")); } return position; } - private void decodeDataFields(Position position, int count, String[] values) { + private void decodeDataFields(Position position, String[] values) { if (values.length > 1 && !values[1].isEmpty()) { position.set("tempData", values[1]);