Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change a method for preventing package based mapper scan #258

Closed
AngusLean opened this issue Sep 5, 2018 · 1 comment
Closed

Change a method for preventing package based mapper scan #258

AngusLean opened this issue Sep 5, 2018 · 1 comment
Assignees
@kazuki43zoo
Labels
enhancement
Milestone
2.0.0

Comments

@AngusLean
Copy link

In class MybatisAutoConfiguration line ConflictingBeanDefinitionException 209, the registerBeanDefinitions method catch a IllegalStateException exception, when a ConflictingBeanDefinitionException is happen, usually it's ignored。But in many case, conflict Mapper class is wrong design that should be know in startup time，debug log is weak.

So, should i pull a PR to change this behavior?
@kazuki43zoo
Copy link
Member

@AngusLean Thanks for your reporting!

I guess it is logic for ignoring an error that occurred by the AutoConfigurationPackages#get(), but I think you opinion are right.

@kazuki43zoo kazuki43zoo self-assigned this Sep 13, 2018
@kazuki43zoo kazuki43zoo added this to the 2.0.0 milestone Jan 8, 2019
@kazuki43zoo kazuki43zoo mentioned this issue Jan 12, 2019
Merged
@kazuki43zoo kazuki43zoo changed the title Why MybatisAutoConfiguration catch ConflictingBeanDefinitionException? Change a method for preventing package based mapper scan Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazuki43zoo kazuki43zoo

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@kazuki43zoo @AngusLean