Subject: [PATCH] use records --- Index: src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableDefect.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableDefect.java b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableDefect.java --- a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableDefect.java (revision 7d36682856085f9d06a83bd3e7f3224ea3243327) +++ b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableDefect.java (date 1716541000801) @@ -15,22 +15,7 @@ */ package org.apache.ibatis.submitted.collection_injection.immutable; -public class ImmutableDefect { - private final int id; - private final String defect; - - public ImmutableDefect(int id, String defect) { - this.id = id; - this.defect = defect; - } - - public int getId() { - return id; - } - - public String getDefect() { - return defect; - } +public record ImmutableDefect(int id, String defect) { @Override public String toString() { Index: src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoomDetail.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoomDetail.java b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoomDetail.java --- a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoomDetail.java (revision 7d36682856085f9d06a83bd3e7f3224ea3243327) +++ b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoomDetail.java (date 1716541000803) @@ -15,33 +15,11 @@ */ package org.apache.ibatis.submitted.collection_injection.immutable; -public class ImmutableRoomDetail { - - private final String wallType; - private final int wallHeight; - private final int roomSize; - - public ImmutableRoomDetail(final String wallType, final int wallHeight, final int roomSize) { - this.wallType = wallType; - this.wallHeight = wallHeight; - this.roomSize = roomSize; - } - - public String getWallType() { - return wallType; - } - - public int getWallHeight() { - return wallHeight; - } - - public int getRoomSize() { - return roomSize; - } +public record ImmutableRoomDetail(String wallType, int wallHeight, int roomSize) { @Override public String toString() { return "ImmutableRoomDetail{" + "wallType='" + wallType + '\'' + ", wallHeight=" + wallHeight + ", roomSize=" - + roomSize + '}'; + + roomSize + '}'; } } Index: src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoom.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoom.java b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoom.java --- a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoom.java (revision 7d36682856085f9d06a83bd3e7f3224ea3243327) +++ b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableRoom.java (date 1716541000799) @@ -17,38 +17,11 @@ import java.util.List; -public class ImmutableRoom { - private final int id; - private final String name; - private final ImmutableRoomDetail roomDetail; - private final List furniture; - - public ImmutableRoom(int id, String name, ImmutableRoomDetail roomDetail, List furniture) { - this.id = id; - this.name = name; - this.roomDetail = roomDetail; - this.furniture = furniture; - } - - public int getId() { - return id; - } - - public String getName() { - return name; - } - - public ImmutableRoomDetail getRoomDetail() { - return roomDetail; - } - - public List getFurniture() { - return furniture; - } +public record ImmutableRoom(int id, String name, ImmutableRoomDetail roomDetail, List furniture) { @Override public String toString() { return "ImmutableRoom{" + "id=" + id + ", name='" + name + '\'' + ", roomDetail=" + roomDetail + ", furniture=" - + furniture + '}'; + + furniture + '}'; } } Index: src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableHouse.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableHouse.java b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableHouse.java --- a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableHouse.java (revision 7d36682856085f9d06a83bd3e7f3224ea3243327) +++ b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableHouse.java (date 1716541000805) @@ -17,28 +17,7 @@ import java.util.List; -public class ImmutableHouse { - private final int id; - private final String name; - private final List rooms; - - public ImmutableHouse(int id, String name, List rooms) { - this.id = id; - this.name = name; - this.rooms = rooms; - } - - public int getId() { - return id; - } - - public String getName() { - return name; - } - - public List getRooms() { - return rooms; - } +public record ImmutableHouse(int id, String name, List rooms) { @Override public String toString() { Index: src/test/java/org/apache/ibatis/submitted/collection_injection/CollectionInjectionTest.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/src/test/java/org/apache/ibatis/submitted/collection_injection/CollectionInjectionTest.java b/src/test/java/org/apache/ibatis/submitted/collection_injection/CollectionInjectionTest.java --- a/src/test/java/org/apache/ibatis/submitted/collection_injection/CollectionInjectionTest.java (revision 7d36682856085f9d06a83bd3e7f3224ea3243327) +++ b/src/test/java/org/apache/ibatis/submitted/collection_injection/CollectionInjectionTest.java (date 1716541000802) @@ -61,16 +61,16 @@ Assertions.assertNotNull(house); final StringBuilder builder = new StringBuilder(); - builder.append("\n").append(house.getName()); - for (ImmutableRoom room : house.getRooms()) { - ImmutableRoomDetail roomDetail = room.getRoomDetail(); - String detailString = String.format(" (size=%d, height=%d, type=%s)", roomDetail.getRoomSize(), - roomDetail.getWallHeight(), roomDetail.getWallType()); - builder.append("\n").append("\t").append(room.getName()).append(detailString); - for (ImmutableFurniture furniture : room.getFurniture()) { - builder.append("\n").append("\t\t").append(furniture.getDescription()); - for (ImmutableDefect defect : furniture.getDefects()) { - builder.append("\n").append("\t\t\t").append(defect.getDefect()); + builder.append("\n").append(house.name()); + for (ImmutableRoom room : house.rooms()) { + ImmutableRoomDetail roomDetail = room.roomDetail(); + String detailString = String.format(" (size=%d, height=%d, type=%s)", roomDetail.roomSize(), + roomDetail.wallHeight(), roomDetail.wallType()); + builder.append("\n").append("\t").append(room.name()).append(detailString); + for (ImmutableFurniture furniture : room.furniture()) { + builder.append("\n").append("\t\t").append(furniture.description()); + for (ImmutableDefect defect : furniture.defects()) { + builder.append("\n").append("\t\t\t").append(defect.defect()); } } } Index: src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableFurniture.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableFurniture.java b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableFurniture.java --- a/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableFurniture.java (revision 7d36682856085f9d06a83bd3e7f3224ea3243327) +++ b/src/test/java/org/apache/ibatis/submitted/collection_injection/immutable/ImmutableFurniture.java (date 1716541000804) @@ -17,32 +17,11 @@ import java.util.List; -public class ImmutableFurniture { - private final int id; - private final String description; - private final List defects; - - public ImmutableFurniture(int id, String description, List defects) { - this.id = id; - this.description = description; - this.defects = defects; - } - - public int getId() { - return id; - } - - public String getDescription() { - return description; - } - - public List getDefects() { - return defects; - } +public record ImmutableFurniture(int id, String description, List defects) { @Override public String toString() { return "ImmutableFurniture{" + "id=" + id + ", description='" + description + '\'' + ", defects='" + defects + '\'' - + '}'; + + '}'; } }