Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surprised with release 1.11 #757

Closed
parmentelat opened this issue Mar 25, 2021 · 1 comment · Fixed by #758
Closed

surprised with release 1.11 #757

parmentelat opened this issue Mar 25, 2021 · 1 comment · Fixed by #758

Comments

@parmentelat
Copy link
Contributor

hi
this seems to be linked to #753 and/or #754 but as I don't know exactly which is which, I'm creating this new thread

I was taken by surprise after - not deliberately - deploying 1.11

my use case is this
. I have courses written as notebooks; because my students run this on their own computer I want the jupytext config to be embedded in the notebooks - so I don't know anything about this jupytext.toml that I've seen mentioned in the PRs
. I generally use md:myst, less often py:percent
. I find that saving the version numbers is only creating noise in git diffs, so I turn them off
. and I have a few extra settings of my own in the metadata; in the example below I have a nbhosting subsection in there
. my settings so far look like this

jupytext:
  cell_metadata_filter: all,-hidden,-heading_collapsed
  notebook_metadata_filter: all,-language_info,-toc,-jupytext.text_representation.jupytext_version,-jupytext.text_representation.format_version
  text_representation:
    extension: .md
    format_name: myst

and until 1.10.* eveything was fine;

however I just found that with 1.11 my notebooks would not save properly; saving a notebook without any change results in this diff

image

where you can see that my own metadata has gone, and the 2 versions I wanted to get rid of have resurrected


can you please help me out here; I have tried to read about that but could not find with certainty how to handle this properly


as a side note, I deliberately do not set formats: because I found that in some corner cases (when people try to 'download as...' iirc) that this setting was in the way

thanks !!

@mwouts
Copy link
Owner

mwouts commented Mar 25, 2021

Hi @parmentelat , thanks for reporting this.

I thought this use case was covered with tests but it was not, sorry.
I'll add more tests to make sure I catch the issue above and will soon release a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants