Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupytext's MyBinder link is broken #559

Closed
mwouts opened this issue Jul 6, 2020 · 6 comments · Fixed by #573 or #574
Closed

Jupytext's MyBinder link is broken #559

mwouts opened this issue Jul 6, 2020 · 6 comments · Fixed by #573 or #574
Milestone

Comments

@mwouts
Copy link
Owner

mwouts commented Jul 6, 2020

The MyBinder launch fails. Apparently it's trying to parse jupytext.py as a configuration file when converting the get_started.md notebook 😄
Screenshot from 2020-07-06 22-06-19

@mwouts mwouts added this to the 1.5.2 milestone Jul 14, 2020
@mgeier
Copy link

mgeier commented Jul 23, 2020

It still doesn't seem to work, I'm still getting the same error: https://mybinder.org/v2/gh/mwouts/jupytext/master?urlpath=lab/tree/demo/get_started.ipynb

@mwouts
Copy link
Owner Author

mwouts commented Jul 23, 2020

Hi @mgeier , I think this is because of the cache - as I don't have an explicit requirement for jupytext>=1.5.2 in binder/requirements.txt, MyBinder was still using the version 1.5.1 for some time.

On my side I now see it working at https://notebooks.gesis.org/binder/jupyter/user/mwouts-jupytext-jv21wl2s/lab . Is (the beginning of) your URL different? I mean, do you hit a different server with a different cache than mine?

@mgeier
Copy link

mgeier commented Jul 23, 2020

Oh, interesting!

I don't even get an URL, because the build is not successful.

I think you shouldn't put jupytext into the requirements.txt at all, you should make a "dev" install in postBuild. Then such problems cannot occur.

@mwouts
Copy link
Owner Author

mwouts commented Jul 23, 2020

Good idea! I'll do that.

@mgeier
Copy link

mgeier commented Jul 23, 2020

Thanks, now it works perfectly!

@mwouts
Copy link
Owner Author

mwouts commented Jul 23, 2020

Excellent! And thank you for keeping an eye this, Matthias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants