Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Port component #4792

Closed
4 tasks
nathanmarks opened this issue Jul 21, 2016 · 4 comments
Closed
4 tasks

[Select] Port component #4792

nathanmarks opened this issue Jul 21, 2016 · 4 comments
Labels
component: select This is the name of the generic UI component, not the React module!

Comments

@nathanmarks
Copy link
Member

nathanmarks commented Jul 21, 2016

  • Component
  • Tests (at least unit tests)
  • Docs
  • Demo

Previous attempt:

@nathanmarks nathanmarks added this to the 0.16.0 Release milestone Jul 21, 2016
@nathanmarks nathanmarks removed the ready label Aug 14, 2016
@nathanmarks nathanmarks self-assigned this Aug 28, 2016
@oliviertassinari oliviertassinari modified the milestone: v1.0.0-prerelease Jul 14, 2017
@ctavan
Copy link
Contributor

ctavan commented Jul 17, 2017

I would love to get porting of the SelectField component going again. I checked out the referenced issues, mainly #6608 however to be honest I'm unsure what the ultimate conclusion of #6608 actually was.

So far I started rebasing the branch from #6608 onto the current v1-alpha branch, see v1-alpha...ctavan:v1-select-field

However in the current form the examples yield endless re-render loops so I'll dig further into it.

I'm happy to continue working on this and bringing this into a mergeable shape, however I would need some guidance from you as to what the feature set of the SelectField should actually be, in particular in comparison to Autocomplete functionality, which has been discussed in #6608 but I don't see a final conclusion on this.

So any input with respect to what scope a SelectField component in Material-UI should have would be highly appreciated and I'm happy to do further work on this.

@rosskevin
Copy link
Member

@ctavan I believe we have decided to leave Autocomplete as a sample only, providing underlying components, but not to provide such a high level component ourselves.

See #7477

@ctavan
Copy link
Contributor

ctavan commented Jul 31, 2017

Makes a lot of sense! I will try to bring the SelectField into a reasonable state over the next few days but I'll try to restrict it as much as possible to be really more like a html <select> replacement and keep all more complex functionality out of scope.

See #7458

@rosskevin
Copy link
Member

Closing as duplicate of #5716

@rosskevin rosskevin marked this as a duplicate of #5716 Aug 2, 2017
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: select This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

5 participants