We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a proposal of how we may improve the fontWeight prop in the system.
fontWeight
system
This is how it looks currently:
<Box fontWeight="fontWeightRegular" />
The first option of how we may improve it is by the following usage:
<Box fontWeight="regular" />
where we would pull values from theme.typography.fontWeightX Related to #17615
theme.typography.fontWeightX
The other option is to use the following:
<Box fontWeight="body1.fontWeight" />
where we would be still pulling from theme.typography.x.
theme.typography.x
First reported in #23053 (comment)
I am in favor of the second approach, but I am open for opinion from others :)
The text was updated successfully, but these errors were encountered:
Option 2. is already supported, I think that option 1 and 2 are complementary and will be welcomed.
A proposal, we can make it systematic for the other typography values. We could have:
x: 'default'
x: 'y'
This would solve #17615 from @lcswillems but also simplify
<Box fontFamily="fontFamily" />
to
<Box fontFamily="default" />
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Summary 💡
This is a proposal of how we may improve the
fontWeight
prop in thesystem
.This is how it looks currently:
Option 1
The first option of how we may improve it is by the following usage:
where we would pull values from
theme.typography.fontWeightX
Related to #17615Option 2
The other option is to use the following:
where we would be still pulling from
theme.typography.x
.First reported in #23053 (comment)
I am in favor of the second approach, but I am open for opinion from others :)
The text was updated successfully, but these errors were encountered: