-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge cut off when added to MenuItem #21639
Comments
Reproduction on https://codesandbox.io/s/material-demo-0p6l3?file=/demo.tsx. It seems that we can simply remove the overflow style. I don't see any good motivation for this style. Git blame doesn't yield any useful information, the style come from: 9a9ea7e#diff-97d43fceafba5d21cb2646aaa9483e54R16. diff --git a/packages/material-ui/src/MenuItem/MenuItem.js b/packages/material-ui/src/MenuItem/MenuItem.js
index 2f44f7a75..f0faeedfb 100644
--- a/packages/material-ui/src/MenuItem/MenuItem.js
+++ b/packages/material-ui/src/MenuItem/MenuItem.js
@@ -13,7 +13,6 @@ export const styles = (theme) => ({
paddingBottom: 6,
boxSizing: 'border-box',
width: 'auto',
- overflow: 'hidden',
whiteSpace: 'nowrap',
[theme.breakpoints.up('sm')]: {
minHeight: 'auto', |
I would like to work on this issue if no one else has started |
You guys rock, thanks a lot! 💯 |
It will be released in v5.0.0-alpha.2 this weekend |
When adding a
<Badge>
to a<MenuItem>
, it appears cut off:Current Behavior 😯
Badge is cut off
Expected Behavior 🤔
Badge isn't cut off
Steps to Reproduce 🕹
Context 🔦
Adding notifications to a navigation menu is a common use case
Your Environment 🌎
The text was updated successfully, but these errors were encountered: