Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Make primary the default color #21594

Merged
merged 10 commits into from
Jun 30, 2020
Merged

[Button] Make primary the default color #21594

merged 10 commits into from
Jun 30, 2020
+181 −508

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Jun 27, 2020 •
edited by oliviertassinari
Loading

Breaking change

  • The button color prop is now "primary" by default, and "default" has been removed. This makes the button closer to the Material Design specification and simplifies the API.
-<Button color="default" />
-<Button color="primary" />
+<Button />
+<Button />

Closes #17530

Sorry, something went wrong.

@mbrookes mbrookes added breaking change component: button This is the name of the generic UI component, not the React module! labels Jun 27, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 27, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 02e7759

@github-actions github-actions bot mentioned this pull request Jun 27, 2020
Closed
@oliviertassinari

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@mbrookes mbrookes changed the title [Button] deprecate default color for primary [Button] remove default color Jun 27, 2020
@mbrookes
[Button] Make primary the default color

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
3b8676d
@mbrookes mbrookes force-pushed the button-color-deprecate-default branch from 367c7bb to 3b8676d Compare June 27, 2020 21:47
@mbrookes mbrookes changed the title [Button] remove default color [Button] Make primary the default color Jun 27, 2020
@mbrookes

This comment has been minimized.

Sign in to view
mbrookes added 2 commits June 28, 2020 03:01
@mbrookes
types, api docs

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
554707b
@mbrookes
tests

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
aebbafd
@mbrookes mbrookes force-pushed the button-color-deprecate-default branch from 6c1fc78 to aebbafd Compare June 28, 2020 02:42
@mbrookes
stray demo & types

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
fbcbfec
oliviertassinari
oliviertassinari requested changes Jun 28, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

  • I could only find this case to fix:

Capture d’écran 2020-06-28 à 17 30 27

  • Could you also update the migration guide?

@mbrookes
remove default from contained buttons demo

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
3983327
@mbrookes
Copy link
Member Author

Could you also update the migration guide?

It was done already:

https://github.com/mui-org/material-ui/pull/21594/files?file-filters%5B%5D=.md#diff-019068d088cdf7a1aeda9214a944a589

@mbrookes
fix Global CSS example

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
ed33f75
oliviertassinari
oliviertassinari reviewed Jun 28, 2020
View reviewed changes
docs/src/pages/guides/migration-v4/migration-v4.md Outdated
Comment on lines 65 to 67
```
/(<Button(\n*.*?)*?)color="primary"/$1/g
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a regex (in Vim search and replace format) that removes color="primary" from Buttons.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, maybe we should explain? I don't know how to use it. Do we have something that can work with VScode?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's omit it.

@mbrookes @oliviertassinari
Apply suggestions from code review

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
0c58efe 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@mbrookes @oliviertassinari
Update docs/src/pages/guides/migration-v4/migration-v4.md

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
a33f834 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
mbrookes and others added 2 commits June 28, 2020 23:32
@mbrookes
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7c580a3
@oliviertassinari
Update docs/src/pages/guides/migration-v4/migration-v4.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
02e7759
@oliviertassinari oliviertassinari merged commit c9e2181 into mui:next Jun 30, 2020
@oliviertassinari
Copy link
Member

Capture d’écran 2020-06-30 à 23 35 43

We have missed this regression. @mbrookes Could you have a look? :)

@mbrookes mbrookes deleted the button-color-deprecate-default branch July 1, 2020 00:05
@eps1lon eps1lon added this to the v5 milestone Jul 20, 2020
@eps1lon eps1lon mentioned this pull request Aug 5, 2020
Closed
42 tasks
@Jack-Works Jack-Works mentioned this pull request Apr 30, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari

Assignees
No one assigned
Labels
breaking change component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.

[Button] Remove default color, use primary by default
4 participants
@mbrookes @mui-pr-bot @oliviertassinari @eps1lon