Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MobileStepper] Fix TypeScript props not aligning with prop-types #19594

Merged
merged 1 commit into from
Feb 6, 2020
Merged

[MobileStepper] Fix TypeScript props not aligning with prop-types #19594

merged 1 commit into from
Feb 6, 2020
+2 −2

Conversation

illusionalsagacity
Copy link
Contributor

Sorry, something went wrong.

@illusionalsagacity
fix[MobileStepper]: ts types not aligning with prop-types

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
794489e
@mui-pr-bot
Copy link

No bundle size changes comparing 3764e63...794489e

Generated by 🚫 dangerJS against 794489e

@oliviertassinari oliviertassinari changed the title [MobileStepper]: Fix typescript props not aligning with prop-types [MobileStepper] Fix TypeScript props not aligning with prop-types Feb 6, 2020
@oliviertassinari oliviertassinari added component: stepper This is the name of the generic UI component, not the React module! typescript labels Feb 6, 2020
dimitropoulos
dimitropoulos approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@oliviertassinari oliviertassinari merged commit 5728e5f into mui:master Feb 6, 2020
@illusionalsagacity illusionalsagacity deleted the fix-mobilestepper-types branch February 6, 2020 22:43
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@illusionalsagacity @EsoterikStare
[MobileStepper] Fix TypeScript props not aligning with prop-types (mu…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
be54464 
…i#19594)
This was referenced Mar 10, 2020
Merged
Merged
Merged
Closed
Closed
Closed
This was referenced Mar 21, 2020
Merged
Open
This was referenced Apr 16, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari

@dimitropoulos dimitropoulos

Assignees
No one assigned
Labels
component: stepper This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illusionalsagacity @mui-pr-bot @oliviertassinari @dimitropoulos