-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building requires poetry-dynamic-versioning to be previously installed. #126
Comments
Poetry itself doesn't actually use the |
Gotcha, thanks for the clarification! This also explains why CIBuildWheel would correctly install poetry-dynamic-versioning. Thank you! |
Hi, I am having this same issue. What would be the best way of action for building the packages inside of github actions? |
for a standard, pure python package, you can reference my github actions pipeline here: https://github.com/BrianPugh/python-template/blob/main/.github/workflows/deploy.yaml If you have dependencies that need to be compiled, you can check out my much more complicated pipeline here: https://github.com/BrianPugh/python-template/blob/main/.github/workflows/build_wheels.yaml |
Hi, thanks for the reference action. It is now working! https://github.com/Dioptas/Dioptas/blob/develop/.github/workflows/CD.yml The main thing i needed to add was this: - name: Add Dynamic Versioning Plugin
run: |
poetry self add poetry-dynamic-versioning[plugin] before building. Installing dependencies is not required for building. |
Seems like when I try to use your Python template and run
Any idea @BrianPugh? |
Currently, I'm trying to run
poetry build --format=sdist
in a github action, but the resulting tar.gz file has version0.0.0
. This is right after installing via snok/install-poetry. Point is, this is from a very clean poetry installation (I am also able to reproduce in a docker container).My
pyproject.toml
contains:I would expect for the poetry build-system (or is actually upstream to poetry?) to install poetry-dynamic-versioning for me since it's listed in
requires
.If I explicitly install poetry-dynamic-versioning (admittedly, as the README says to do), then run my build command, everything is fine:
Is this working-as-intended, a bug, or an upstream issue? Thanks!
Poetry version: 1.5.1 (latest)
The text was updated successfully, but these errors were encountered: