add mingw-w64-ardour, need proper path relocation

[Biswa96]

Here is the PKGBUILD that I have used to create the mingw-w64-ardour package.

_realname=ardour
pkgbase=mingw-w64-${_realname}
pkgname=("${MINGW_PACKAGE_PREFIX}-${_realname}")
pkgver=8.4
pkgrel=1
pkgdesc="Professional-grade digital audio workstation (mingw-w64)"
arch=('any')
mingw_arch=('mingw64' 'ucrt64' 'clang64' 'clangarm64')
url='https://ardour.org/'
license=('spdx:GPL-2.0-or-later')
depends=(
  "${MINGW_PACKAGE_PREFIX}-aubio"
  "${MINGW_PACKAGE_PREFIX}-cairomm"
  "${MINGW_PACKAGE_PREFIX}-curl"
  "${MINGW_PACKAGE_PREFIX}-fluidsynth"
  "${MINGW_PACKAGE_PREFIX}-glib2"
  "${MINGW_PACKAGE_PREFIX}-glibmm"
  "${MINGW_PACKAGE_PREFIX}-libarchive"
  "${MINGW_PACKAGE_PREFIX}-liblo"
  "${MINGW_PACKAGE_PREFIX}-libsndfile"
  "${MINGW_PACKAGE_PREFIX}-libusb"
  "${MINGW_PACKAGE_PREFIX}-libwebsockets"
  "${MINGW_PACKAGE_PREFIX}-lilv"
  "${MINGW_PACKAGE_PREFIX}-lv2"
  "${MINGW_PACKAGE_PREFIX}-pangomm"
  "${MINGW_PACKAGE_PREFIX}-portaudio"
  "${MINGW_PACKAGE_PREFIX}-rubberband"
  "${MINGW_PACKAGE_PREFIX}-serd"
  "${MINGW_PACKAGE_PREFIX}-sord"
  "${MINGW_PACKAGE_PREFIX}-sratom"
  "${MINGW_PACKAGE_PREFIX}-taglib"
  "${MINGW_PACKAGE_PREFIX}-vamp-plugin-sdk"
)
makedepends=(
  "${MINGW_PACKAGE_PREFIX}-boost"
  "${MINGW_PACKAGE_PREFIX}-cc"
  "git"
  "python"
)
_commit="c35515e43d65bac23c89ae11cfbf2fed8c8f46b6"
source=("git+https://github.com/Ardour/ardour.git#commit=${_commit}")
sha256sums=('SKIP')

build() {
  cd "${_realname}"

  export WAF_NO_PREFORK=1

  export CFLAGS+=" -Wno-deprecated-declarations"
  export CXXFLAGS+=" -Wno-deprecated-declarations"

  /usr/bin/python ./waf configure \
    --prefix=${MINGW_PREFIX} \
    --check-c-compiler=${CC} \
    --dist-target=mingw \
    --optimize \
    --no-dr-mingw \
    --no-fpu-optimization \
    --no-nls \
    --no-phone-home \
    --out="${srcdir}/build-${MSYSTEM}"

  /usr/bin/python ./waf build
}

package() {
  cd "${_realname}"
  /usr/bin/python ./waf install --destdir="${pkgdir}"
}

It needs proper path relocation. I can not figure out a proper way to do that. Many source files have DATA_DIR, CONFIG_DIR, LOCALEDIR etc. and those macros are defined to full msys2 installation path. If anyone try to solve the issue feel free to copy the above idea and continue to work.

[Biswa96]

Also, here is the required patches to solve some linking issue.

diff --git a/gtk2_ardour/main.cc b/gtk2_ardour/main.cc
index d585b834c0..778cd9f21c 100644
--- a/gtk2_ardour/main.cc
+++ b/gtk2_ardour/main.cc
@@ -261,7 +261,7 @@ int main (int argc, char *argv[])
 
 	load_custom_fonts(); /* needs to happen before any gtk and pango init calls */
 
-	if (!Glib::thread_supported()) {
+	if (!g_thread_supported()) {
 		Glib::thread_init();
 	}
 
diff --git a/gtk2_ardour/wscript b/gtk2_ardour/wscript
index 0869f99a23..c2dcdf5600 100644
--- a/gtk2_ardour/wscript
+++ b/gtk2_ardour/wscript
@@ -673,7 +673,7 @@ def build(bld):
         obj.source += [ 'lv2_plugin_ui.cc' ]
         obj.use += [ 'SUIL' ]
 
-    if bld.is_defined('HAVE_FFTW35F') and bld.env['build_target'] != 'mingw':
+    if bld.is_defined('HAVE_FFTW35F'):
         bld.env['LIB_FFTW3F'] += ['fftw3f_threads']
 
     if bld.is_defined('NEED_INTL'):
diff --git a/libs/ardour/wscript b/libs/ardour/wscript
index 57494c0c9e..7ccf50ebbe 100644
--- a/libs/ardour/wscript
+++ b/libs/ardour/wscript
@@ -355,6 +355,7 @@ def configure(conf):
 
     if conf.env['WINDOWS_VST_SUPPORT'] == True:
         conf.check(compiler='cxx', lib='gdi32', mandatory=True, uselib_store='GDI32')
+    conf.check(compiler='cxx', lib='bcrypt', mandatory=True, uselib_store='BCRYPT')
 
 def build(bld):
     # Library version (UNIX style major, minor, micro)
@@ -436,6 +437,7 @@ def build(bld):
         obj.includes += [ '../fst' ]
         obj.use += [ 'vstwin' ]
         obj.uselib += ['GDI32']
+    obj.uselib += ['BCRYPT']
 
     if bld.is_defined('LXVST_SUPPORT'):
         obj.source += [ 'lxvst_plugin.cc', 'linux_vst_support.cc' ]
diff --git a/libs/fst/wscript b/libs/fst/wscript
index 725cd9ec15..df174a38ef 100644
--- a/libs/fst/wscript
+++ b/libs/fst/wscript
@@ -12,6 +12,7 @@ def options(opt):
 def configure(conf):
     if conf.env['WINDOWS_VST_SUPPORT'] == True:
         conf.check(compiler='cxx', lib='gdi32', mandatory=True, uselib_store='GDI32')
+    conf.check(compiler='cxx', lib='bcrypt', mandatory=True, uselib_store='BCRYPT')
 
 def build(bld):
     if bld.is_defined('VST3_SUPPORT'):
@@ -35,6 +36,7 @@ def build(bld):
             obj.uselib += ' OSX'
         if bld.env['build_target'] == 'mingw':
             obj.uselib += ' GDI32'
+            obj.uselib += ' BCRYPT'
             obj.linkflags = ['-mwindows']
 
         if re.search ("bsd", sys.platform) != None:
diff --git a/libs/pbd/pbd.cc b/libs/pbd/pbd.cc
index 67b6b2adb1..b4da3092bc 100644
--- a/libs/pbd/pbd.cc
+++ b/libs/pbd/pbd.cc
@@ -86,7 +86,7 @@ PBD::init ()
 	}
 #endif
 
-	if (!Glib::thread_supported()) {
+	if (!g_thread_supported()) {
 		Glib::thread_init();
 	}

[Kreijstal]

oh darn it, you're too fast, I managed to make it work on CI, using msys2 without pkgbuild, actually, it builds and installs, but as soon as you try to do it in the makepkg command, it errors.

Actually, I get the error, that cc can't be found, I assume it is because of this path relocation.

# project  configured on Mon Feb 26 19:42:23 2024 by
# waf 2.0.26 (abi 20, python 30b08f0 on win32)
# using waf configure -vvv --check-cxx-compiler=g++ --check-c-compiler=gcc --prefix=C:/Users/topkek/scoop/apps/msys2/2024-01-13/ucrt64 --dist-target=mingw --configdir=C:/Users/topkek/scoop/apps/msys2/2024-01-13/share --cxx11 --freedesktop --no-phone-home --optimize --ptformat --use-external-libs --with-backends=portaudio,dummy,jack
#
----------------------------------------
Setting top to
C:/Users/topkek/scoop/persist/msys2/home/topkek/git/MINGW-packages/mingw-w64-ardour/src/ardour
----------------------------------------
Setting out to
C:/Users/topkek/scoop/persist/msys2/home/topkek/git/MINGW-packages/mingw-w64-ardour/src/ardour/build
----------------------------------------
Checking for 'gcc' (C compiler)
find program=['gcc', 'cc'] paths=['C:\\Users\\topkek\\scoop\\apps\\msys2\\2024-01-13\\ucrt64\\bin', 'C:\\Users\\topkek\\scoop\\apps\\msys2\\2024-01-13\\usr\\local\\bin', 'C:\\Users\\topkek\\scoop\\apps\\msys2\\2024-01-13\\usr\\bin', 'C:\\Users\\topkek\\scoop\\apps\\msys2\\2024-01-13\\usr\\bin', 'C:\\Windows\\System32', 'C:\\Windows', 'C:\\Windows\\System32\\Wbem', 'C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\', 'C:\\Users\\topkek\\scoop\\apps\\msys2\\2024-01-13\\usr\\bin\\site_perl', 'C:\\Users\\topkek\\scoop\\apps\\msys2\\2024-01-13\\usr\\bin\\vendor_perl', 'C:\\Users\\topkek\\scoop\\apps\\msys2\\2024-01-13\\usr\\bin\\core_perl'] var='CC' -> ['gcc']
from C:/Users/topkek/scoop/persist/msys2/home/topkek/git/MINGW-packages/mingw-w64-ardour/src/ardour: Program ['gcc'] is not executable
not found
from C:/Users/topkek/scoop/persist/msys2/home/topkek/git/MINGW-packages/mingw-w64-ardour/src/ardour: could not configure a C compiler!

this builds however outside of the makepkg

[Biswa96]

hint: mingw-w64-mpv was built with waf build system before it was ported to meson. I got the idea to fix some issues from there. See the mingw-w64-mpv PKGBUILD file before it was ported to meson.

[Kreijstal]

hint: mingw-w64-mpv was built with waf build system before it was ported to meson. I got the idea to fix some issues from there. See the mingw-w64-mpv PKGBUILD file before it was ported to meson.

hmm, is it a waf bug? something we can upstream?

[Biswa96]

I do not know what causes that issue and never see that.

[Kreijstal]

I just discovered a debugging trick: add exec bash to the pkgbuild, debug to your hearts content