Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation failed on macOS: Too many levels of symbolic links #66

Closed
huangqinjin opened this issue May 1, 2023 · 7 comments
Closed

Comments

@huangqinjin
Copy link
Contributor

macOS uses a case-insensitive filesystem.

@mstorsjo
Copy link
Owner

mstorsjo commented May 1, 2023

This issue should be fixed by the commits in https://github.com/mstorsjo/msvc-wine/commits/macos (which also adds a CI setup for this case). If you think those commits look fine, I could push them to the master branch.

@huangqinjin
Copy link
Contributor Author

@mstorsjo LGTM!

@huangqinjin
Copy link
Contributor Author

Could you please enable CI on pull request?

@mstorsjo
Copy link
Owner

mstorsjo commented May 2, 2023

@mstorsjo LGTM!

Thanks; I pushed the fix commit to master now. I didn't include the one adding it to CI yet though as I wasn't sure if the changes in #65 can be fixed to work the same on non-Linux (but you can carry it in your branch temporarily to try it out).

(I haven't had time to read up on your responses on #65 yet - sorry about that!)

Could you please enable CI on pull request?

Let's see - I pushed dec9213 now, can you try to rebase on top of that?

@huangqinjin
Copy link
Contributor Author

As I stated in #65 (comment) , using fifo works on macOS. So kindly push the CI changes, than I will rebase on top of it.

@mstorsjo
Copy link
Owner

mstorsjo commented May 3, 2023

As I stated in #65 (comment) , using fifo works on macOS. So kindly push the CI changes, than I will rebase on top of it.

Ok, that's done in c64b8f9 now.

@huangqinjin
Copy link
Contributor Author

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants