Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of allele depths for Indels called by Strelka #215

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

sebastianlange
Copy link
Contributor

Fixed handling of alternate and reference allele depths. Currently, only the variant allele depth (from TIR) is translated to MAF. However, the information for the reference allele is similarly located in TAR, which is now extracted as well.

Compare Strelka's updated README: https://github.com/Illumina/strelka/blob/master/docs/userGuide/README.md#somatic

Somatic indels:
tier1RefCounts = First comma-delimited value from FORMAT/TAR
tier1AltCounts = First comma-delimited value from FORMAT/TIR
Somatic allele freqeuncy is $tier1AltCounts / ($tier1AltCounts + $tier1RefCounts)

Fixed handling of alternate and reference allele depths. Currently, only the variant allele depth (from TIR) is translated to MAF. However, the information for the reference allele is similarly located in TAR, which is now extracted as well.  

Compare Strelka's updated README: https://github.com/Illumina/strelka/blob/master/docs/userGuide/README.md#somatic 

Somatic indels:
tier1RefCounts = First comma-delimited value from FORMAT/TAR
tier1AltCounts = First comma-delimited value from FORMAT/TIR
Somatic allele freqeuncy is $tier1AltCounts / ($tier1AltCounts + $tier1RefCounts)
@ckandoth ckandoth self-assigned this Mar 10, 2019
@depths = map{""} @alleles;
$depths[0] = ( split /,/, $fmt_info{TAR} )[0];
$depths[$var_allele_idx] = ( split /,/, $fmt_info{TIR} )[0];

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a closing bracket } here. But otherwise looks good. Thanks for the PR!

@ckandoth ckandoth force-pushed the master branch 5 times, most recently from 5b4013c to 0b91d65 Compare March 11, 2019 17:43
@ckandoth ckandoth changed the base branch from master to develop March 17, 2019 21:29
@ckandoth ckandoth merged commit d7c60e5 into mskcc:develop Mar 17, 2019
@ckandoth
Copy link
Collaborator

I will merge this into develop branch and fix the missing bracket myself. Thanks again for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants