Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory consumption #92

Closed
silverwind opened this issue Aug 8, 2015 · 2 comments
Closed

Memory consumption #92

silverwind opened this issue Aug 8, 2015 · 2 comments

Comments

@silverwind
Copy link
Contributor

This might be more of an v8/node issue, but I'm banging my head on why busboy and other multipart parsers (namely, I've tried formidable and multiparty) seem to make v8 unable to garbage collect uploaded data.

Here's my test case, which can be run locally: https://gist.github.com/silverwind/10f076397348a64a72a5

When uploading a 3.4 GB file, the process first starts out at around 45 MB, then quickly climbs to to size of the uploaded file at 3.5 GB. At this point, the file is written to the disk completely, but the process doesn't go down a bit in memory consumption until killed. At this point, I tried to upload the same file again. My machine with 4 GB + 4 GB swap froze up pretty badly at this point, last I saw it was at around 6.5 GB explicit memory on the node process. I was eventually able to kill the node process, here's how the memory history looked:

screen shot 2015-08-08 at 12 08 19 pm

Note that the graph above is a bit misleading. The explicit consumption of the node process never went down until killed. I think it's the OS making some on-demand memory available, but that's just a guess.

By the way, this is on io.js 3.0.0, but I assume all versions to be affected.

@silverwind
Copy link
Contributor Author

drumroll turns out that this is most likely an io.js/v8 issue as node 0.12.7 is not affected. Now to narrow it down. Edit: io.js 2.5.0 is good, 3.0.0 has it.

@silverwind
Copy link
Contributor Author

Closing as this isn't an issue with this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant