Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of including the dark variant #5

Open
kwyntes opened this issue Nov 13, 2023 · 1 comment
Open

Possibility of including the dark variant #5

kwyntes opened this issue Nov 13, 2023 · 1 comment

Comments

@kwyntes
Copy link

kwyntes commented Nov 13, 2023

Would it be possible to also implement the PaperColor dark variant? I tried to convert the theme.yaml file with the use of a script, mapping the light colours from the original PaperColor repository to their respective dark variants, however it seems like this theme includes a lot of other colours not present in the original PaperColor repository, of which I have absolutely no idea where they all came from.

Since I'm horrible at design/picking colours myself I was hoping there would be an automated way of converting the themes but I'm starting to think this is not going to be possible.

Would it require a complete redesign of this theme to accommodate for the dark variant?

@kwyntes kwyntes changed the title Possibility of including dark variant Possibility of including the dark variant Nov 13, 2023
@mrworkman
Copy link
Owner

Hi @kwyntes

I've considered implementing the dark theme as well, but I think it wouldn't be a quick thing to do. I can't recall if the vim theme's colours map one to one for each element being highlighted or not. If so, then porting the dark theme might not be too big of an undertaking. If not, then it'd be a lot of trial and error to map the colours to the right vscode scopes.

however it seems like this theme includes a lot of other colours not present in the original PaperColor repository, of which I have absolutely no idea where they all came from.

Yep. A few new colours have been added (due to differences in the way vim & vscode are able to highlight code). For a dark theme, new colours would need to be selected.

I'll have a look at the vim theme again to see what I can/can't do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants