Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertSmallDataFrameEquality Scalatest bug #64

Closed
MrPowers opened this issue Mar 15, 2020 · 2 comments
Closed

assertSmallDataFrameEquality Scalatest bug #64

MrPowers opened this issue Mar 15, 2020 · 2 comments

Comments

@MrPowers
Copy link
Collaborator

Screen Shot 2020-03-15 at 3 18 07 PM

The assertSmallDataFrameEquality method always shows the first row as failing, even when it's the same. It's also not adding the line break before printing the first row comparison line.

utest is properly outputting the first line so looks like this bug is only for Scalatest.

Screen Shot 2020-03-15 at 3 08 19 PM

Any suggestions on how to fix this?
@MrPowers MrPowers mentioned this issue Mar 31, 2020
Closed
@carlsverre
Copy link
Contributor

I would print a color reset code as the first line followed by a newline and then the actual/expected message. I think Scalatest is not handing the first color escape code as can be seen in it printing [34m. Possibly it's due to that being followed by [frank which may make the printer consumed for some reason.

@MrPowers MrPowers mentioned this issue Apr 2, 2020
Merged
@MrPowers
Copy link
Collaborator Author

MrPowers commented Mar 1, 2021

This should be fixed now.

@MrPowers MrPowers closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlsverre @MrPowers