diff --git a/docs/api/helpers/SkeletonHelper.html b/docs/api/helpers/SkeletonHelper.html index f7a8ab74a74ace..6ecafd0ad6b3c1 100644 --- a/docs/api/helpers/SkeletonHelper.html +++ b/docs/api/helpers/SkeletonHelper.html @@ -63,11 +63,6 @@

[method:Array getBoneList]( object )

This is called automatically to generate a list of bones from the object passed in the constructor. -

[method:null update]()

-
- Update the helper. Call in the render loop if animating the model. -
-

Source

[link:https://github.com/mrdoob/three.js/blob/master/src/[path].js src/[path].js] diff --git a/docs/scenes/bones-browser.html b/docs/scenes/bones-browser.html index 0ccb48103862a9..ec677fba3e237b 100644 --- a/docs/scenes/bones-browser.html +++ b/docs/scenes/bones-browser.html @@ -253,8 +253,6 @@ } - skeletonHelper.update(); - renderer.render( scene, camera ); } diff --git a/examples/webgl_animation_skinning_blending.html b/examples/webgl_animation_skinning_blending.html index cd87959229e2ee..a6c69a5b796cd9 100644 --- a/examples/webgl_animation_skinning_blending.html +++ b/examples/webgl_animation_skinning_blending.html @@ -524,10 +524,10 @@ } - // Update the animation mixer, the skeleton and the stats panel, and render this frame + // Update the animation mixer, the stats panel, and render this frame mixer.update( mixerUpdateDelta ); - skeleton.update(); + stats.update(); renderer.render( scene, camera ); diff --git a/examples/webgl_animation_skinning_morph.html b/examples/webgl_animation_skinning_morph.html index dece68cb4af031..ad0a016df067de 100644 --- a/examples/webgl_animation_skinning_morph.html +++ b/examples/webgl_animation_skinning_morph.html @@ -655,8 +655,9 @@ camera.lookAt( scene.position ); if( mixer ) { + mixer.update( delta ); - helper.update(); + } renderer.render( scene, camera ); diff --git a/examples/webgl_loader_bvh.html b/examples/webgl_loader_bvh.html index 5fa8f35f84fcb2..9e4314a003c32b 100644 --- a/examples/webgl_loader_bvh.html +++ b/examples/webgl_loader_bvh.html @@ -101,7 +101,6 @@ var delta = clock.getDelta(); if ( mixer ) mixer.update( delta ); - if ( skeletonHelper ) skeletonHelper.update(); renderer.render( scene, camera ); diff --git a/examples/webgl_loader_x.html b/examples/webgl_loader_x.html index f06533da0bfff8..9f4ffb98f95acd 100644 --- a/examples/webgl_loader_x.html +++ b/examples/webgl_loader_x.html @@ -261,8 +261,6 @@ } - if (Models != null && Models.length > 0 && skeletonHelper != null) { skeletonHelper.update(); } - stats.update(); render(); diff --git a/src/helpers/SkeletonHelper.js b/src/helpers/SkeletonHelper.js index 73d3fd327f26ce..f718c3040a4c2f 100644 --- a/src/helpers/SkeletonHelper.js +++ b/src/helpers/SkeletonHelper.js @@ -54,7 +54,7 @@ function SkeletonHelper( object ) { this.matrix = object.matrixWorld; this.matrixAutoUpdate = false; - this.update(); + this.onBeforeRender(); } @@ -82,14 +82,14 @@ SkeletonHelper.prototype.getBoneList = function( object ) { }; -SkeletonHelper.prototype.update = function () { +SkeletonHelper.prototype.onBeforeRender = function () { var vector = new Vector3(); var boneMatrix = new Matrix4(); var matrixWorldInv = new Matrix4(); - return function update() { + return function onBeforeRender() { var geometry = this.geometry; var position = geometry.getAttribute( 'position' ); @@ -122,5 +122,10 @@ SkeletonHelper.prototype.update = function () { }(); +SkeletonHelper.prototype.update = function () { + + // backwards compatability + +}; export { SkeletonHelper };