Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion to firefox #93

Open
imperialofficial opened this issue Jul 28, 2019 · 3 comments
Open

conversion to firefox #93

imperialofficial opened this issue Jul 28, 2019 · 3 comments

Comments

@imperialofficial
Copy link

Hello, i am trying to port this extension to firefox for personal pleasure, i ve replaced all chrome. to .browser since the firefox api supports it but i am out of lack:/ can you give me some advise for the next steps?
Thank you very much and have a nice day!

@dvalter
Copy link

dvalter commented Dec 31, 2019

full page screen capture miss "<all_urls>" permission to capture tab content in Firefox. Also it uses WebKit/Blink specific filesystem API, so the code also should be rewritten.

By the way you don't want to replace chrome with browser since browser uses futures instead of callbacks in Chrome, and Firefox tries to mimic.

@phanirithvij
Copy link

Is there a firefox alternative for this extension?

@chemtrails
Copy link

I wouldn't port this code to Firefox. FF is way more permissive than Chrome. Also, this repo doesn't contain any other features of the GoFullPage extension. So the functionality of this repo is basically one line in Firefox browser.tabs.captureTab(), which I use in FullCap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants