Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic observer and system registration #18

Closed
mrchantey opened this issue Jan 26, 2025 · 1 comment · Fixed by #32
Closed

Automatic observer and system registration #18

mrchantey opened this issue Jan 26, 2025 · 1 comment · Fixed by #32
Labels
A-Control-Flow Control flow systems like behavior trees C-Feature A new feature, making something new possible
Milestone

Comments

@mrchantey
Copy link
Owner

Its very difficult to remember to register each action for a given scene, and its also hard to know which default ones are registered by the LifecyclePlugin

We should add typeids to a hashset on register, and check that set on add with lifecycle hook. If its missing id like this to panic by default, with options for warning or ignore. I cant think of a use-case where its a desired configuration.

@mrchantey mrchantey changed the title Panic if action not registered Automatic observer and system registration Feb 1, 2025
@mrchantey
Copy link
Owner Author

Im changing the scope of this issue to automatic registration instead of panicking. The reason we can do this is an action Component is inseperable from its observers and systems, its different from vanilla components, observers and systems that have much looser relationships.

@mrchantey mrchantey added this to the 0.0.5 milestone Feb 1, 2025
@mrchantey mrchantey added A-Control-Flow Control flow systems like behavior trees C-Feature A new feature, making something new possible labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Control-Flow Control flow systems like behavior trees C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant