-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsuback user callback is invoked with no context #1512
Comments
This is an automated message to let you know that this issue has If this issue is still important, you can simply comment with a Thank you for your contribution. |
@bretambrose would you like to submit a PR? |
This is an automated message to let you know that this issue has If this issue is still important, you can simply comment with a Thank you for your contribution. |
The unsuback handler calls the user callback with null:
MQTT.js/lib/client.js
Lines 1657 to 1662 in accd78e
There doesn't seem to be a way to get any of the reason codes from the unsuback (let alone reason string and user properties).
Adding the packet to the callback invocation might not be a breaking change, but it might also be a surprise if the recipient was used to a null value for the packet.
The text was updated successfully, but these errors were encountered: