From 441b1b6d418279ed78328887520e6ff16ee5ec81 Mon Sep 17 00:00:00 2001
From: saintsebastian <tilitidam@gmail.com>
Date: Mon, 17 Oct 2016 20:45:58 +0200
Subject: [PATCH] fix: `web-ext sign` no longer logs an irrelevant temp
 directory path (#577)

---
 src/cmd/build.js | 13 +++++++++----
 src/cmd/sign.js  |  3 ++-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/cmd/build.js b/src/cmd/build.js
index a0e625ef27..0502c1ce89 100644
--- a/src/cmd/build.js
+++ b/src/cmd/build.js
@@ -37,6 +37,7 @@ export type PackageCreatorParams = {
   sourceDir: string,
   fileFilter: FileFilter,
   artifactsDir: string,
+  showReadyMessage: boolean
 };
 
 export type LocalizedNameParams = {
@@ -78,8 +79,8 @@ export type PackageCreatorFn =
     (params: PackageCreatorParams) => Promise<ExtensionBuildResult>;
 
 async function defaultPackageCreator(
-  {manifestData, sourceDir, fileFilter, artifactsDir}: PackageCreatorParams
-): Promise<ExtensionBuildResult> {
+  {manifestData, sourceDir, fileFilter, artifactsDir, showReadyMessage,
+}: PackageCreatorParams): Promise<ExtensionBuildResult> {
   let id;
   if (manifestData) {
     id = getManifestId(manifestData);
@@ -110,7 +111,9 @@ async function defaultPackageCreator(
 
   await streamToPromise(stream);
 
-  log.info(`Your web extension is ready: ${extensionPath}`);
+  if (showReadyMessage) {
+    log.info(`Your web extension is ready: ${extensionPath}`);
+  }
   return {extensionPath};
 }
 
@@ -128,6 +131,7 @@ export type BuildCmdOptions = {
   fileFilter?: FileFilter,
   onSourceChange?: OnSourceChangeFn,
   packageCreator?: PackageCreatorFn,
+  showReadyMessage?: boolean
 };
 
 export default async function build(
@@ -136,13 +140,14 @@ export default async function build(
     manifestData, fileFilter = new FileFilter(),
     onSourceChange = defaultSourceWatcher,
     packageCreator = defaultPackageCreator,
+    showReadyMessage = true,
   }: BuildCmdOptions = {}
 ): Promise<ExtensionBuildResult> {
   const rebuildAsNeeded = asNeeded; // alias for `build --as-needed`
   log.info(`Building web extension from ${sourceDir}`);
 
   const createPackage = () => packageCreator({
-    manifestData, sourceDir, fileFilter, artifactsDir,
+    manifestData, sourceDir, fileFilter, artifactsDir, showReadyMessage,
   });
 
   await prepareArtifactsDir(artifactsDir);
diff --git a/src/cmd/sign.js b/src/cmd/sign.js
index 8d7d3cd0a5..d5046cce8b 100644
--- a/src/cmd/sign.js
+++ b/src/cmd/sign.js
@@ -70,7 +70,8 @@ export default function sign(
       }
 
       let [buildResult, idFromSourceDir] = await Promise.all([
-        build({sourceDir, artifactsDir: tmpDir.path()}, {manifestData}),
+        build({sourceDir, artifactsDir: tmpDir.path()},
+              {manifestData, showReadyMessage: false}),
         getIdFromSourceDir(sourceDir),
       ]);