Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Fira is only used for unsupported-browser message #391

Closed
digitarald opened this issue Aug 2, 2017 · 2 comments
Closed

Fira is only used for unsupported-browser message #391

digitarald opened this issue Aug 2, 2017 · 2 comments
Milestone
Stretch 🙆‍♀️

Comments

@digitarald
Copy link

Cutting the custom font download could cut down load time and remove the extraneous fira.css.
@pdehaan
Copy link
Contributor

pdehaan commented Aug 2, 2017

Possibly related to #278; "Lazy load some assets".

@pdehaan
Copy link
Contributor

pdehaan commented Aug 3, 2017

Actually, since Fira seems to only be used on the /unsupported/:reason page(s), the easiest solution would be to move that <link rel="stylesheet" href="https://code.cdn.mozilla.net/fonts/fira.css"> tag into the /views/unsupported.handlebars view.

Although it is not ideal to put a stylesheet in the body, so maybe there is a way we can include it in the <head> based on some Handlebars view variable/helper.

@dannycoates dannycoates modified the milestone: Stretch Aug 3, 2017
@pdehaan pdehaan mentioned this issue Aug 3, 2017
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stretch 🙆‍♀️
Development

No branches or pull requests
3 participants
@digitarald @dannycoates @pdehaan