Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed explanations for uncacheable flags #379

Closed
Jake-Shadle opened this issue Feb 20, 2019 · 3 comments
Closed

Add more detailed explanations for uncacheable flags #379

Jake-Shadle opened this issue Feb 20, 2019 · 3 comments

Comments

@Jake-Shadle
Copy link
Contributor

While it's great that uncacheable flags have a high level "TooHard/Flag" attached to them, it would be really helpful to have a link to an issue for each one that explains why, as right now it's kind of disappointing to hit on an uncacheable compiler call, but not really have a detailed reason for why the flag is "hard". I opened #378 because it was apparent from the code why it was considered hard, but other ones aren't as clear immediately.

@luser
Copy link
Contributor

luser commented Feb 20, 2019

Not a bad idea. I guess we could re-enable the project wiki here and make a page with sections describing why we don't handle particular flags or scenarios and then print links to the proper section in the stats output. Currently the non-cacheable reasons are just stored as HashMap<String, usize>:

pub not_cached: HashMap<String, usize>,

so we'd need to change that to have a place to store the URLs. Printing them in the --show-stats output would be straightforward:

if !self.not_cached.is_empty() {

@Jake-Shadle
Copy link
Contributor Author

That sounds even better than what I was thinking. 😄

@TriplEight
Copy link

That would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants