Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

Problem with an automated review: Review message should indicate which diff it applies to. #1848

Closed
glandium opened this issue Feb 6, 2019 · 1 comment
Closed

Problem with an automated review: Review message should indicate which diff it applies to. #1848

glandium opened this issue Feb 6, 2019 · 1 comment
Assignees
@abpostelnicu
Labels
app:staticanalysis/bot

Comments

@glandium
Copy link

glandium commented Feb 6, 2019

Phabricator URL: https://phabricator.services.mozilla.com/D18807

Problem: The review message should indicate which diff it applies to. In this case, I ran clang format between the first and the second diffs attached to the revision, but before the bot said anything, so I guess the review applies to the first. But it should be clearer.
@glandium glandium changed the title Problem with an automated review: SUMMARY Problem with an automated review: Review message should indicate which diff it applies to. Feb 6, 2019
@La0 La0 self-assigned this Feb 6, 2019
@sylvestre
Copy link
Contributor

Yeah, instead of having
Code analysis found 1 defect in this patch:
we could have
Code analysis found 1 defect in this patch (Diff 104147):

Would be much more clear

@La0 La0 assigned abpostelnicu and unassigned La0 May 17, 2019
@La0 La0 closed this as completed in 6ee4d10 May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abpostelnicu abpostelnicu

Labels
app:staticanalysis/bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@La0 @sylvestre @glandium @abpostelnicu