"Take a note..." placeholder text is not displayed when erasing all text from the Notes content area

[SoftVision-EmilPasca]

[Affected versions]:

• Firefox 57 and up

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a Firefox profile with the latest "Firefox Notes" add-on version (1.9.0b1 build with CKeditor) installed.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Select all the text from the content area and delete it.
3. Observe the "Take a note..." placeholder text.

[Expected result]:

• "Take a note..." placeholder text is displayed.

[Actual result]:

• "Take a note..." placeholder text is not displayed.

[Additional Notes]:

• Attached a screen recording of the issue:
  

[Natim]

https://docs.ckeditor.com/ckeditor5/latest/api/module_engine_viewithplaceholder.html

[vladikoff]

Ref: ckeditor/ckeditor5#479

[Natim]

Shall we plug https://github.com/alexeckermann/ckeditor5-emptyness ?

[Natim]

@anweshknayak Do you want to tackle this one?

[muddlebee]

Hey @Natim sure 💯 . Thanks 😄

[muddlebee]

Sorry, I don't get this one. Take a note placeholder. What are you referring to?

[Natim]

When the pad is empty (in the previous version notes) we had a placeholder telling people to take a note.

Since we moved to CKeditor we don't have it anymore.

I guess we need to plug this plugin: https://github.com/alexeckermann/ckeditor5-emptyness in order to add it back.

[vladikoff]

[Expected result]:

"Take a note..." placeholder text is displayed.

We improved our "Welcome" copy and probably won't be bringing the old "Take a note..." placeholder unless CKEditor makes it really easy to add it.