From a00bbf254695679e9c1acdd297d8f3dfe222fcf7 Mon Sep 17 00:00:00 2001 From: James Hugman Date: Fri, 14 Oct 2022 14:30:06 +0100 Subject: [PATCH 1/3] Disable sdk-not-ready event --- components/nimbus/metrics.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/components/nimbus/metrics.yaml b/components/nimbus/metrics.yaml index e211b7a2a9..d7abe617b8 100644 --- a/components/nimbus/metrics.yaml +++ b/components/nimbus/metrics.yaml @@ -125,9 +125,11 @@ nimbus_health: feature_id: type: string description: The feature id of the configuration that was requested + disabled: true bugs: - https://mozilla-hub.atlassian.net/browse/EXP-2689 - https://mozilla-hub.atlassian.net/browse/EXP-2690 + - https://mozilla-hub.atlassian.net/browse/EXP-2852 data_reviews: - https://github.com/mozilla/application-services/pull/5091#issuecomment-1218359426 data_sensitivity: @@ -144,8 +146,10 @@ nimbus_health: feature_id: type: string description: The feature id of the configuration that was requested + disabled: true bugs: - https://mozilla-hub.atlassian.net/browse/EXP-2743 + - https://mozilla-hub.atlassian.net/browse/EXP-2852 data_reviews: - https://github.com/mozilla/application-services/pull/5118#issuecomment-1235827006 data_sensitivity: From 2ee0ddef3ba7aadf5b6d94e5fb10ce6e8e1be390 Mon Sep 17 00:00:00 2001 From: James Hugman Date: Fri, 14 Oct 2022 14:32:46 +0100 Subject: [PATCH 2/3] Add changelog --- CHANGES_UNRELEASED.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGES_UNRELEASED.md b/CHANGES_UNRELEASED.md index 329f07a0de..d139ca14fd 100644 --- a/CHANGES_UNRELEASED.md +++ b/CHANGES_UNRELEASED.md @@ -18,3 +18,8 @@ Use the template below to make assigning a version number during the release cut - Description of the change with a link to the pull request ([#0000](https://github.com/mozilla/application-services/pull/0000)) --> + +## Nimbus ⛅️🔬🔭 + +### What's Changed + - Disabled Glean events recorded when the SDK is not ready for a feature ([#5185](https://github.com/mozilla/application-services/pull/5185)) From 7facbf10a8bf79c3e177ee926a07490f0485f8f1 Mon Sep 17 00:00:00 2001 From: James Hugman Date: Fri, 14 Oct 2022 16:02:12 +0100 Subject: [PATCH 3/3] Ignore test for disabled metrics --- .../src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt b/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt index 7d8473cc01..af262b07ee 100644 --- a/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt +++ b/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt @@ -25,6 +25,7 @@ import org.junit.Assert.assertNull import org.junit.Assert.assertTrue import org.junit.Assert.assertFalse import org.junit.Before +import org.junit.Ignore import org.junit.Rule import org.junit.Test import org.junit.runner.RunWith @@ -461,6 +462,7 @@ class NimbusTests { } @Test + @Ignore fun `in memory cache not ready logs an event`() { // we haven't initialized nimbus at all, it should not log any error, but it should log an // event