Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-components-swift includes all components in the same namespace #4820

Closed
tarikeshaq opened this issue Feb 3, 2022 · 1 comment
Closed
Labels

Comments

@tarikeshaq
Copy link
Contributor

tarikeshaq commented Feb 3, 2022

This is a follow up to #4815

With the v91.0.1 release of rust-components-swift all the component's swift code is released as one target. Meaning that name conflicts across components will fail to compile.

For now, that's okay, we don't have any name conflicts in the components we ship to iOS and focus. But, there are name conflicts in tabs and autofill. It's not a hard problem to workaround, we just rename whatever is conflicting, but we might want a better story for this

┆Issue is synchronized with this Jira Task

@mhammond
Copy link
Member

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866349

Change performed by the Move to Bugzilla add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants