Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Hot Words into binaries #3336

Closed
3 tasks done
lissyx opened this issue Sep 25, 2020 · 8 comments
Closed
3 tasks done

Expose Hot Words into binaries #3336

lissyx opened this issue Sep 25, 2020 · 8 comments
Assignees

Comments

@lissyx
Copy link
Collaborator

lissyx commented Sep 25, 2020

This is a follow-up of #3297: new API entry points have been added and exposed in all bindings.

This bug is about replicating what has been done in #3297 for using this new API in the Python binary and do that in all our other binaries, as well as add CI testing:

Anyone willing to take care of that is welcome to ask more details, here or on Matrix. This is a good way to get into the project: it's technically easy but it touches several places as well as CI testing, so you get a nice overview of the surface.

@imrahul361
Copy link
Contributor

I like to work on it? Is it available? @lissyx

@lissyx
Copy link
Collaborator Author

lissyx commented Oct 1, 2020

I like to work on it? Is it available? @lissyx

Yes, you are welcome. I guess it'd be more efficient if you can join us on Matrix for helping you about the codebase!

@imrahul361
Copy link
Contributor

Ok Sure @lissyx

@imrahul361
Copy link
Contributor

What's the room name? @lissyx

@ftyers
Copy link
Collaborator

ftyers commented Oct 1, 2020

@imrahul361
Copy link
Contributor

I am on it. Trying to fix the issue @ftyers

@lissyx
Copy link
Collaborator Author

lissyx commented Dec 8, 2020

Thanks @imrahul361 I've taken your last PR and landed it.

@imrahul361
Copy link
Contributor

imrahul361 commented Dec 8, 2020

Ok thank you 😁 and sorry again for the delay @lissyx

@lissyx lissyx closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants