Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed metadata in exported model #1770

Closed
reuben opened this issue Dec 7, 2018 · 5 comments
Closed

Embed metadata in exported model #1770

reuben opened this issue Dec 7, 2018 · 5 comments
Assignees
@reuben

Comments

@reuben
Copy link
Contributor

reuben commented Dec 7, 2018

  • Language
  • Minimum client version that is compatible with the model
  • Hyperparameters
  • Other stuff?
@reuben
Copy link
Contributor Author

reuben commented Dec 12, 2018

I thought it'd be easier to add this to the graph as a constant node, but I can't figure out how to coax the freezing process into keeping the constants in the resulting graph, so I'm removing this from the v0.4 release.

I think the easiest solution for this would be to use protobuf directly to edit the output frozen graph. Not sure if it's worth the effort.

@reuben reuben mentioned this issue Jan 9, 2019
Closed
@reuben reuben self-assigned this Apr 1, 2019
@reuben reuben removed the help wanted label Apr 1, 2019
@reuben
Copy link
Contributor Author

reuben commented Apr 1, 2019

Trying again with an alternative approach, using protobuf but with messages built-in to TensorFlow, so minimal effort.

@reuben
Copy link
Contributor Author

reuben commented Apr 2, 2019

For the TFLite model there's no easy solution right now. The model file has a description field that's currently unused, but the TFLite converter API doesn't expose it, so it's not easy to use. For now I'll focus on the protobuf model since that's what we run the prod tests with.

@reuben
Copy link
Contributor Author

reuben commented Apr 5, 2019

Fixed in #1919.

@reuben reuben closed this as completed Apr 5, 2019
@lock
Copy link

lock bot commented May 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reuben reuben

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reuben