Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataops-ci-bot should rebase before generating schemas #686

Open
fbertsch opened this issue Jun 21, 2021 · 0 comments
Open

Dataops-ci-bot should rebase before generating schemas #686

fbertsch opened this issue Jun 21, 2021 · 0 comments

Comments

@fbertsch
Copy link
Contributor

The dataops-ci-bot currently generates schemas for main and HEAD, and compares them. The problem is that sometimes compatible commits will exist on main but not on HEAD, which look like incompatible schema changes when comparing schemas. For example, if there is an additional field on main, it will look like it's missing on HEAD, when in fact it will be added during the rebase commit.

We should first rebase on main before running the integration tests. That will show the actual changes between main and HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant