Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Dockerfile.public #1310

Open
bhearsum opened this issue Apr 11, 2023 · 0 comments
Open

Get rid of Dockerfile.public #1310

bhearsum opened this issue Apr 11, 2023 · 0 comments

Comments

@bhearsum
Copy link
Contributor

After #1304 lands, Dockerfile and Dockerfile.public will be identical except for their CMD. These can be fairly easily combined by setting /app/docker.d/init.sh as the ENTRYPOINT, and then ensuring anything that starts instances sets the appropriate CMD. For docker-compose.yml this is easy, but we also need to deal with our staging and production deployments, which do not set either currently. Before we can do this I suggest that we make the following changes to them:

  • Pull the same image for both admin and public
  • Configure k8s to set the appropriate CMD for each (it's probably best to delegate ENTRYPOINT to the Dockerfile, although I could be convinced otherwise)

I don't see any way to do this as a non-breaking change, so we'll want to have changes to this repo and cloudops-infra ready to go around the same time. Changes to either one of them are likely to trigger a deploy, so I suggest we land as follows:

  • Push the cloudops-infra change first -- which will almost certainly fail to deploy due to the current images lacking an ENTRYPOINT
  • Push the change to this repo. That should trigger a deploy that will then succeed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant