From 052986267fa5502cab5da8ea16fcc54f753fc45e Mon Sep 17 00:00:00 2001 From: Mihir Patel Date: Thu, 8 Aug 2024 13:32:14 -0400 Subject: [PATCH 1/2] try hasattr check --- .github/workflows/daily.yaml | 3 --- composer/loggers/wandb_logger.py | 6 +++++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/daily.yaml b/.github/workflows/daily.yaml index aa97c755c8..d7616ffbbf 100644 --- a/.github/workflows/daily.yaml +++ b/.github/workflows/daily.yaml @@ -77,13 +77,10 @@ jobs: pytest-command: ${{ matrix.pytest_command }} pytest-markers: ${{ matrix.markers }} composer_package_name: ${{ matrix.composer_package_name }} - pytest-wandb-entity: "mosaicml-public-integration-tests" - pytest-wandb-project: "integration-tests-${{ github.sha }}" safe_directory: composer secrets: aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - wandb-api-key: ${{ secrets.WANDB_API_KEY }} code-eval-device: ${{ secrets.CODE_EVAL_DEVICE }} code-eval-url: ${{ secrets.CODE_EVAL_URL }} code-eval-apikey: ${{ secrets.CODE_EVAL_APIKEY }} diff --git a/composer/loggers/wandb_logger.py b/composer/loggers/wandb_logger.py index 4a2afe5c84..7e6dd5c4f2 100644 --- a/composer/loggers/wandb_logger.py +++ b/composer/loggers/wandb_logger.py @@ -200,7 +200,11 @@ def init(self, state: State, logger: Logger) -> None: if self._enabled: wandb.init(**self._init_kwargs) assert wandb.run is not None, 'The wandb run is set after init' - entity_and_project = [str(wandb.run.entity), str(wandb.run.project)] + if hasattr(wandb.run, 'entity') and hasattr(wandb.run, 'project'): + entity_and_project = [str(wandb.run.entity), str(wandb.run.project)] + else: + # Run does not have attribtues if wandb is in disabled mode + entity_and_project = [None, None] self.run_dir = wandb.run.dir self.run_url = wandb.run.get_url() atexit.register(self._set_is_in_atexit) From 6c93d0060fd1ea43c469240e44024f4a82edd920 Mon Sep 17 00:00:00 2001 From: Mihir Patel Date: Thu, 8 Aug 2024 13:43:56 -0400 Subject: [PATCH 2/2] fix wandb --- composer/loggers/wandb_logger.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/composer/loggers/wandb_logger.py b/composer/loggers/wandb_logger.py index 7e6dd5c4f2..d76ee1fbac 100644 --- a/composer/loggers/wandb_logger.py +++ b/composer/loggers/wandb_logger.py @@ -203,8 +203,8 @@ def init(self, state: State, logger: Logger) -> None: if hasattr(wandb.run, 'entity') and hasattr(wandb.run, 'project'): entity_and_project = [str(wandb.run.entity), str(wandb.run.project)] else: - # Run does not have attribtues if wandb is in disabled mode - entity_and_project = [None, None] + # Run does not have attribtues if wandb is in disabled mode, so we must mock it + entity_and_project = ['disabled', 'disabled'] self.run_dir = wandb.run.dir self.run_url = wandb.run.get_url() atexit.register(self._set_is_in_atexit)