Suggestion: use remappings instead of relative paths for external dependencies

[0xJem]

IMetaMorpho.sol contains the following imports from OZ and Morpho Blue:

import {IMorpho, Id, MarketParams} from "../../lib/morpho-blue/src/interfaces/IMorpho.sol";
import {IERC4626} from "../../lib/openzeppelin-contracts/contracts/interfaces/IERC4626.sol";
import {IERC20Permit} from "../../lib/openzeppelin-contracts/contracts/token/ERC20/extensions/IERC20Permit.sol";

If the integrator does not have the dependencies at these exact locations, it's not possible to compile a contract integrating with the IMetaMorpho interface.

Scenarios where this would break:

• Integrator has the dependencies with a version string (e.g. lib/morpho-blue-1.0.0/)
• Integrator is using soldeer to manage dependencies (e.g. dependencies/morpho-blue-1.0.0/)

It does also not appear to be possible to add a relative path into the remappings.txt file to force forge/solc to remap the relative path. i.e. this does not work ../../lib/morpho-blue/src/=dependencies/morpho-blue-1.0.0/src/

[Rubilmax]

If the integrator does not have the dependencies at these exact locations

In which case is this possible? Aren't you installing this repository as a forge dependency (git submodule under-the-hood)?

Relative dependencies are safer than remappings because the versions of contracts are exact (whereas remappings can map OUR dependency import to YOURS - possibly breaking)

[MathisGD]

The reason why we don't use remapping it precisely to make sure that our dependancies are used (instead of other ones, whatever they are). Remappings can create dangerous bugs.

As @Rubilmax said, it's best to use our repos as git submodule (to recursively have the dependancies).

I'm not familiar with soldeer, but can't it fetch all the dependancies recursively?

[0xJem]

In which case is this possible? Aren't you installing this repository as a forge dependency (git submodule under-the-hood)?

A dependency can be added at a custom location when using forge install. Soldeer also uses a different directory structure.

The reason why we don't use remapping it precisely to make sure that our dependancies are used

Right, this makes sense! I can probably add it to our setup script to set up the metamorpho dependencies. Thanks for the tip and explanation.