Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port over SICBlockCipher, switch AES to CTR by default #27

Open
GoogleCodeExporter opened this issue Mar 12, 2015 · 0 comments
Open

Port over SICBlockCipher, switch AES to CTR by default #27

GoogleCodeExporter opened this issue Mar 12, 2015 · 0 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

AESCipher initializes with:

        this.cipher = new PaddedBufferedBlockCipher(new CBCBlockCipher(cipher));

CBC is subject to Padding Oracle attacks 
(https://blog.skullsecurity.org/2013/padding-oracle-attacks-in-depth). 

It would probably be worthwhile porting over SICBlockCipher (bouncy castle's 
CTR mode) and switching the default to CTR.

Original issue reported on code.google.com by quickte...@gmail.com on 14 Feb 2014 at 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter