0.16.2.2: Failing to build vst plugin

[dvzrv]

Hi!

When trying to build from the newly established source tarball, I also tried building the vst plugin (--enable-vst).

This currently leads to a failing build though. This is the build log:
giada-0.16.2.2-build.log

[monocasual]

Oh I remember this one. Which version of gcc are you using?

[dvzrv]

Yeah, this seems to be the same problem as helm is having.

$ gcc --version
gcc (Arch Linux 9.3.0-1) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[monocasual]

Tested right now with

gcc (Debian 8.3.0-6) 8.3.0

and it builds OK. Maybe gcc 9.x is more picky about it?

[dvzrv]

Yeah, for gcc >= 9.1.0 this commit (juce-framework/JUCE@4e0adb2) has to be backported.

[monocasual]

BTW, Is VST necessary for you? If I remember correctly Linux distros used to keep VST disabled due to some licensing issues. Can I publish a new point release as requested by eeickmeyer in #315 ?

[dvzrv]

Well, VST is problematic, if using the steinberg sdk and having to host it as a package (this is not allowed).
On Linux there are several ways to emulate vst though, with replacement headers and the JUCE way of doing things also seems to work.

That being said: Sure, release away! We can fix this later.

[hfiguiere]

The build failure is because of JUCE. I have a patch as I said in #324.

See: https://github.com/flathub/flathub/pull/1626/files#diff-63233e04f2dfa20f73841db33649d8fb

giada-juce.patch.txt

[gvnnz]

@dvzrv @hfiguiere is this still an issue?

[hfiguiere]

the current version no longer build VST2 because the VST2 SDK isn't available anymore.

As for that JUCE problem, it has been solved a while ago in JUCE.