Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve riemann-redis tool #60

Closed
inkel opened this issue Mar 29, 2013 · 2 comments
Closed

Improve riemann-redis tool #60

inkel opened this issue Mar 29, 2013 · 2 comments

Comments

@inkel
Copy link

inkel commented Mar 29, 2013

Current riemann-redis tool only accepts host, port and (optional) password to connect to a Redis server. However it's better if it would additionally would accept an URL in case the user want to connect using via TCP or via socket. Auth is also possible to be specified from there.

Also it currently issues an INFO and sends all the data converted to float by using #to_f. While this conversion is possible for most of the values returned by INFO, some values are actually strings, which will be converted to 0 in that case, most notably aof_last_bgrewrite_status and rdb_last_bgsave_status, which reports ok or error.

Last but not least, Redis 2.6+ allows to query just for a section of the metrics, so it would be nice if each metric could be tagged properly depending on its section:

  • server: General information about the Redis server
  • clients: Client connections section
  • memory: Memory consumption related information
  • persistence: RDB and AOF related information
  • stats: General statistics
  • replication: Master/slave replication information
  • cpu: CPU consumption statistics
  • commandstats: Redis command statistics
  • cluster: Redis Cluster section
  • keyspace: Database related statistics

If anybody wants to join me, feel free to leave a comment, criticism or suggestion.

@inkel
Copy link
Author

inkel commented Mar 29, 2013

See riemann/riemann-tools#29

@obfuscurity
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants