-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display saved date for gifts #5080
Comments
Hi @mgrhm , Can you make a PR with the ready markup? I will then make a few corrections to your code. I guess it won't require too much code. |
Hi @sktlmarat. I really have absolutely no idea where to start with this -- I know a bit of HTML, a bit of CSS, but no PHP or Javascript at all. I've looked at the code in
I’m really not sure if this is right, though, and I'm grateful for any input you have. |
@mgrhm, I need css/html of this. |
Sorry -- I don't actually have CSS or HTML for that. It's just an image that I edited using Paintbrush to add the date onto a screenshot. I've spent some time this afternoon trying to work out which CSS classes would apply, but I have genuinely no idea -- I can't make heads nor tails of either the generated output or the |
Fixed by #5081 |
This issue has been automatically locked since there |
The ability to add a date to a gift was added by @sktlmarat in #4909, and works. Monica correctly saves and stores the date of the gift. Unfortunately, it doesn't by default display this date in a useful fashion -- it's hidden and only visible when switching into 'Edit' mode.
This information is too useful to hide by default. I tried to add this myself by editing
Gifts.vue
, but I don't know any Javascript and couldn't make head nor tails of it. I wasn't able to add it in myself.I've made a mockup of where I think would be a good place for it, and attached it to this issue. (It's on the right hand side of the gift's title bar.)
The text was updated successfully, but these errors were encountered: