Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Life event spelling: Tatoo #1924

Closed
jatls opened this issue Oct 16, 2018 · 3 comments · Fixed by #1925
Closed

Life event spelling: Tatoo #1924

jatls opened this issue Oct 16, 2018 · 3 comments · Fixed by #1925
Labels
bug i18n Internationalization

Comments

@jatls
Copy link

jatls commented Oct 16, 2018

Life event says "Tatoo" but correct spelling is "Tattoo".

@asbiin asbiin added bug i18n Internationalization labels Oct 16, 2018
@DanielKim1
Copy link

DanielKim1 commented Oct 18, 2018

rg --files-with-matches tatoo | xargs sed -i 's/tatoo/tattoo/g' && rg --files-with-matches Tatoo | xargs sed -i 's/Tatoo/Tattoo/g' seems to do the job, but it makes changes to several very large files in public/js/ that are impossible to check manually. Is there any risk that changes to these files will break things?

The files are:

  • public/js/lang/app.js
  • public/js/lang/ar.json
  • public/js/lang/cs.json
  • public/js/lang/de.json

and so on.

@asbiin
Copy link
Member

asbiin commented Oct 18, 2018

@DanielKim1 There are some files to change, but any of 'public/js/lang': these are generated files.
See #1875 for another example of life event misspell.

@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug i18n Internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants