Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolute URLs to include markdowns are sourced inside docs/ #185

Closed
MarcBresson opened this issue Dec 1, 2023 · 4 comments · Fixed by #186
Closed

absolute URLs to include markdowns are sourced inside docs/ #185

MarcBresson opened this issue Dec 1, 2023 · 4 comments · Fixed by #186
Labels
documentation Improvements or additions to documentation

Comments

@MarcBresson
Copy link
Contributor

Hello,

I am trying to include a markdown file in another from its absolute URL. The URL i'm trying to include is "docs/includes/blabla.md" from a file in "docs/other/example.md", but it fails.

To make it work, I must remove the docs/ folder. It gives: "includes/blabla.md".

Is it a configuration issue on my end or should the example given in the readme.md of this repo be updated?

@mondeja
Copy link
Owner

mondeja commented Dec 1, 2023

I am trying to include a markdown file in another from its absolute URL.

Please, share the example code. If is an absolute URL should work. How is the URL? What example are you referring to?

@MarcBresson
Copy link
Contributor Author

the file structure is like that

.
- docs
  - includes
    - blabla.md
  - other
    - examples.md

and in examples.md, calling the code below will not work

# header

{%
   include-markdown "docs/includes/blabla.md"
%}

but doing the following is ok:

# header

{%
   include-markdown "includes/blabla.md"
%}

@mondeja mondeja added the documentation Improvements or additions to documentation label Dec 1, 2023
@mondeja
Copy link
Owner

mondeja commented Dec 1, 2023

Yeah, that's correct. The examples in the documentation are not updated. Do you want to open a PR to fix them?

FYI: The breaking change was introduced in v6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants