Fix to rad-nud OBC on normal velocities #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also a fix to normal vel rad-nud. - Changes a few answers.
- A test for division by zero is made but the parameters being tested are uninitialized. - I moved the loop to within the overall `if (OBC%number_of_segments > 0)` so that I could rely on the setting of the parameters to zero. - However, this problem occurred because the parameters are only read if Flather BCs are being used. If they are not it seems the tracer reservoir parameters are not read - it might work by chance but this does requirement for Flather does not seem correct to me. @khedstrom ? - Detected by NCI tests, thanks @nicjhan: https://accessdev.nci.org.au/jenkins/job/mom-ocean.org/job/MOM6_run/build=DEBUG,compiler=intel,experiment=ocean_only-DOME,label=nah599,memory_type=dynamic/139/console
Also try to fix the hanging while killing the job from mask_outside_OBCs if the OBC segments are inconsistent.
- that dying test in MOM_open_boundary hung again...
|
This is being evaluated with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/4138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding various OBC options for evaluation, including reading dvdx and dudy from external files.