Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMP fixes for MOM_diabatic_aus.F90 #551

Merged
merged 1 commit into from
Jul 7, 2017
Merged

OpenMP fixes for MOM_diabatic_aus.F90 #551

merged 1 commit into from
Jul 7, 2017

Conversation

adcroft
Copy link
Collaborator

@adcroft adcroft commented Jul 7, 2017

  • New variables needed to be added to openMP directives.
  • (We should have the Travis compile use openMP to help catch these oversights).

@adcroft
OpenMP fixes for MOM_diabatic_aus.F90
dc2a1c2 
- New variables needed to be added to openMP directives.
- (We should have the Travis compile use openMP to help catch these oversights).
@adcroft adcroft requested a review from Hallberg-NOAA July 7, 2017 21:33
adcroft
adcroft commented Jul 7, 2017
View reviewed changes
Copy link
Collaborator Author

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/2078

@Hallberg-NOAA
Copy link
Collaborator

I will do a compile of this change (by hand) shortly to verify that the code does compile with openMP turned on. I agree that enabling openMP in the Travis compile would be a very good idea, as this is the third or fourth such event of openMP compiles being broken in the last few weeks.

@Hallberg-NOAA Hallberg-NOAA merged commit 9b914f2 into mom-ocean:dev/gfdl Jul 7, 2017
@adcroft adcroft deleted the fix-openmp-diabatic-aux branch July 13, 2017 01:13
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this pull request Oct 9, 2017
@adcroft
MOM6: *Merge branch 'ESMG-user/ksh/open_bc' into dev/gfdl
829ddea 
- Last merge changes answers for circle_obcs

- NOAA-GFDL/MOM6@13a0db7 Fix OpenMP in continuity_PPM
- NOAA-GFDL/MOM6@b12996f *Merge branch 'ESMG-user/ksh/open_bc' into dev/gfdl
- NOAA-GFDL/MOM6@ecf2f52 *Merge branch 'user/ksh/open_bc' of https://github.com/ESMG/MOM6 into ESMG-user/ksh/open_bc
- NOAA-GFDL/MOM6@3c073b6 +Updating OBC ORLANSKI and OBLIQUE algorithms.
- NOAA-GFDL/MOM6@8dc9bcc Merge pull request mom-ocean#561 from adcroft/avoid-segv-obc-hor-visc
- NOAA-GFDL/MOM6@552dc4c Avoids a SEGV when OBC are not in use with bi-harmonic friction
- NOAA-GFDL/MOM6@5a1ceb9 Undoing last commit to MOM_open_boundary.
- NOAA-GFDL/MOM6@29cb063 Merge remote-tracking branch 'gfdl/dev/gfdl' into user/ksh/open_bc
- NOAA-GFDL/MOM6@3768379 Merge pull request mom-ocean#560 from CarolineCardinale/dev/gfdl
- NOAA-GFDL/MOM6@b04b271 Fix trailing spaces Fixed trailing spaces in coord_zlike.
- NOAA-GFDL/MOM6@e0db258 (*) Rescale Regridding
- NOAA-GFDL/MOM6@64787ce +Still more silly value fixes to OBCs.
- NOAA-GFDL/MOM6@66de9ba Merge pull request mom-ocean#559 from adcroft/fix-doxy-errors
- NOAA-GFDL/MOM6@baf4a82 Updated pip requirements.txt
- NOAA-GFDL/MOM6@3dcf630 Merge branch 'fix-doxy-errors' into readthedocs
- NOAA-GFDL/MOM6@c4b5043 Fixes to avoid errors when running doxygen on source
- NOAA-GFDL/MOM6@7607675 Merge pull request mom-ocean#558 from CarolineCardinale/dev/gfdl
- NOAA-GFDL/MOM6@4284075 Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into dev/gfdl
- NOAA-GFDL/MOM6@73a5428 Modification of OBLIQUE OBC.
- NOAA-GFDL/MOM6@02e6e1d Merge remote-tracking branch 'remotes/gfdl/dev/gfdl' into user/ksh/open_bc
- NOAA-GFDL/MOM6@27163ba Revert to ROMSish version of Raymond and Kuo OBC.
- NOAA-GFDL/MOM6@30d292e Merge pull request mom-ocean#557 from adcroft/remove-blanket-h-initialization
- NOAA-GFDL/MOM6@a036c3d Merge pull request mom-ocean#556 from adcroft/avoid-grid-building-on-land
- NOAA-GFDL/MOM6@82fed8f Merge pull request mom-ocean#555 from adcroft/avoid-oob-hor-visc
- NOAA-GFDL/MOM6@330fbb1 White-space.
- NOAA-GFDL/MOM6@aec605c Avoid inviscid warning in single column mode
- NOAA-GFDL/MOM6@de04db1 Avoids building grids on land points
- NOAA-GFDL/MOM6@d596369 Restricts scaling/initialization of h to computational domain
- NOAA-GFDL/MOM6@61f9a22 Avoid allocation/execution in horizontal_viscosity()
- NOAA-GFDL/MOM6@375a8e5 Removed program listing
- NOAA-GFDL/MOM6@2e79064 Return to orig w/o HTML
- NOAA-GFDL/MOM6@122e550 Turned off gen-HTML and listings
- NOAA-GFDL/MOM6@2dddfc8 Try to reduce RTD memory usage
- NOAA-GFDL/MOM6@2de1803 Added Doxygen Comments
- NOAA-GFDL/MOM6@9b914f2 Merge pull request mom-ocean#551 from adcroft/fix-openmp-diabatic-aux
marshallward pushed a commit to marshallward/MOM6 that referenced this pull request Jan 30, 2024
@ashjbarnes
Data table documentation (mom-ocean#551)
435ccaa 
* Update forcing.rst

* add more detail to forcing.rst removing ambiguity about yaml format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallberg-NOAA Hallberg-NOAA Awaiting requested review from Hallberg-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adcroft @Hallberg-NOAA